Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3scale): add backstage example app for 3scale #1268

Merged

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Sep 20, 2024

What does this pull request do

Add backstage example app for 3scale to simplify developement.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Sep 20, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/3scale/packages/app none v0.0.0
backend workspaces/3scale/packages/backend none v0.0.0

workspaces/3scale/packages/backend/src/index.ts Outdated Show resolved Hide resolved
workspaces/3scale/app-config.production.yaml Outdated Show resolved Hide resolved
workspaces/3scale/app-config.yaml Outdated Show resolved Hide resolved
workspaces/3scale/app-config.yaml Outdated Show resolved Hide resolved
workspaces/3scale/app-config.yaml Show resolved Hide resolved
@04kash
Copy link
Contributor

04kash commented Sep 20, 2024

Thanks for this, will definitely simplify development. Just added a few comments

@nickboldt nickboldt self-requested a review September 24, 2024 15:28
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the addExampleAppFor3ScalePlugin branch from cb4da7b to 5ed344a Compare September 26, 2024 11:06
@04kash
Copy link
Contributor

04kash commented Sep 26, 2024

You can remove the changeset for app and backend as we don't want these published (they are only for testing/development). Other than that looks goods!

@vinzscam vinzscam force-pushed the addExampleAppFor3ScalePlugin branch from 0406947 to 2a0638a Compare October 1, 2024 08:42
@nickboldt nickboldt enabled auto-merge (squash) October 2, 2024 14:20
@BethGriggs BethGriggs disabled auto-merge October 2, 2024 14:50
@BethGriggs
Copy link
Collaborator

Hey @AndrienkoAleksandr - would you mind fixing the conflicts in the yarn.lock (probably just needs a rebase and fresh yarn install). This is because we landed #1249 first

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the addExampleAppFor3ScalePlugin branch from 799d4d2 to e397b32 Compare October 2, 2024 20:24
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
@04kash 04kash force-pushed the addExampleAppFor3ScalePlugin branch from e397b32 to 36a9875 Compare October 2, 2024 20:31
@AndrienkoAleksandr
Copy link
Contributor Author

Hey @AndrienkoAleksandr - would you mind fixing the conflicts in the yarn.lock

@BethGriggs done.

@nickboldt nickboldt merged commit becad19 into backstage:main Oct 7, 2024
12 checks passed
karthikjeeyar pushed a commit to karthikjeeyar/community-plugins that referenced this pull request Oct 28, 2024
* feat(3scale): add backstage example app for 3scale

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): handle code review feedback

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): add changesets

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): fix index.ts

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): remove kubernetes frontend plugin

Signed-off-by: Oleksandr Andriienko <[email protected]>

* fix(3scale): remove permission frontend plugin

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): remove tech doc plugin

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): remove plugin-search from app

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): remove docker file

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): remove template

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): remove changeset file

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): dedupe yarn.lock

Signed-off-by: Oleksandr Andriienko <[email protected]>

* feat(3scale): added yarn fixes

Signed-off-by: Oleksandr Andriienko <[email protected]>

---------

Signed-off-by: Oleksandr Andriienko <[email protected]>
Co-authored-by: Kashish Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants