Merge branch 'xenia-canary:canary_experimental' into Custom

.gitignore

@@ -106,4 +106,5 @@ node_modules/.bin/
 /cache
 /cache1
 /cache0
+/devkit
 recent.toml

src/xenia/app/emulator_window.cc

@@ -1902,15 +1902,27 @@ std::string EmulatorWindow::CanonicalizeFileExtension(
   return xe::utf8::lower_ascii(xe::path_to_utf8(path.extension()));
 }
 
-xe::X_STATUS EmulatorWindow::RunTitle(std::filesystem::path path_to_file) {
-  bool titleExists = !std::filesystem::exists(path_to_file);
+xe::X_STATUS EmulatorWindow::RunTitle(
+    const std::filesystem::path& path_to_file) {
+  std::error_code ec = {};
+  bool titleExists = std::filesystem::exists(path_to_file, ec);
+
+  if (path_to_file.empty() || !titleExists) {
+    std::string log_msg =
+        fmt::format("Failed to launch title path is {}.",
+                    path_to_file.empty() ? "empty" : "invalid");
+
+    if (!path_to_file.empty() && !titleExists) {
+      log_msg.append(
+          fmt::format("\nProvided Path: {}", xe::path_to_utf8(path_to_file)));
+    }
 
-  if (path_to_file.empty() || titleExists) {
-    char* log_msg = path_to_file.empty()
-                        ? "Failed to launch title path is empty."
-                        : "Failed to launch title path is invalid.";
+    if (ec) {
+      log_msg.append(fmt::format("\nExtended message info: {} ({:08X})",
+                                 ec.message(), ec.value()));
+    }
 
-    XELOGE(log_msg);
+    XELOGE("{}", log_msg);
 
     imgui_drawer_.get()->ClearDialogs();
 

src/xenia/app/emulator_window.h

@@ -82,7 +82,7 @@ class EmulatorWindow {
 
   void OnEmulatorInitialized();
 
-  xe::X_STATUS RunTitle(std::filesystem::path path_to_file);
+  xe::X_STATUS RunTitle(const std::filesystem::path& path_to_file);
   void UpdateTitle();
   void SetFullscreen(bool fullscreen);
   void ToggleFullscreen();