Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove fp manager #182

Merged
merged 3 commits into from
Dec 4, 2024
Merged

chore: Remove fp manager #182

merged 3 commits into from
Dec 4, 2024

Conversation

gitferry
Copy link
Member

@gitferry gitferry commented Dec 3, 2024

Closes #112. This PR also did some cleanup:

  • move all the loops to event_loops.go
  • remove legacy code

@gitferry gitferry force-pushed the gai/remove-fp-manager branch 2 times, most recently from 599d2e9 to 964f8da Compare December 4, 2024 02:22
@gitferry gitferry marked this pull request as ready for review December 4, 2024 02:31
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

finality-provider/service/errors.go Show resolved Hide resolved
@gitferry gitferry merged commit 807263a into main Dec 4, 2024
12 checks passed
@gitferry gitferry deleted the gai/remove-fp-manager branch December 4, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove finality provider manager
2 participants