enable more linters from golanci-lint #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KonradStaniec
commented
Dec 9, 2024
KonradStaniec
commented
- enables more linters from golang ci lint
- fixes some low hanging fruits
KonradStaniec
requested review from
gitferry and
RafilxTenfen
and removed request for
a team
KonradStaniec
added
the
A:no-changelog
gitferry
approved these changes
Dec 9, 2024
crypto/eots/error.go
Outdated
| @@ -4,17 +4,17 @@ import ( | |||
| ecdsa_schnorr "github.com/decred/dcrd/dcrec/secp256k1/v4/schnorr" | |||
| ) | |||
|
|
|||
| // ErrorKind identifies a kind of error. It has full support for errors.Is | |||
| // KindError identifies a kind of error. It has full support for errors.Is | |||
There was a problem hiding this comment.
Suggested change
| // KindError identifies a kind of error. It has full support for errors.Is | |
| // KindOfError identifies a kind of error. It has full support for errors.Is |
Curious why linter is not happy with ErrorKind?
There was a problem hiding this comment.
apparently convention for error types is to end name with suffix Error (underlying ecdsa_schnorr.ErrorKind does not follow this convention)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.