Merge pull request #76 from babylonchain/move-fp-validaiton-to-embede…

…dscript-method-2

Move fp validaiton to embededscript method 2

package.json

@@ -1,6 +1,6 @@
 {
   "name": "btc-staking-ts",
-  "version": "0.2.9",
+  "version": "0.2.10",
   "description": "Library exposing methods for the creation and consumption of Bitcoin transactions pertaining to Babylon's Bitcoin Staking protocol. Experimental version, should not be used for production purposes or with real funds.",
   "module": "dist/index.js",
   "main": "dist/index.cjs",

src/utils/stakingScript.ts

@@ -127,11 +127,6 @@ export class StakingScriptData {
       return false;
     }
 
-    // Only accept a single finality provider key for now
-    if (this.#finalityProviderKeys.length != 1) {
-      return false;
-    }
-
     return true;
   }
 
@@ -235,9 +230,15 @@ export class StakingScriptData {
    *    OP_RETURN || <serializedStakingData>
    * where serializedStakingData is the concatenation of:
    *    MagicBytes || Version || StakerPublicKey || FinalityProviderPublicKey || StakingTimeLock
+   * Note: Only a single finality provider key is supported for now in phase 1
+   * @throws {Error} If the number of finality provider keys is not equal to 1.
    * @returns {Buffer} The compiled data embed script.
    */
   buildDataEmbedScript(): Buffer {
+    // Only accept a single finality provider key for now
+    if (this.#finalityProviderKeys.length != 1) {
+      throw new Error("Only a single finality provider key is supported");
+    }
     // 1 byte for version
     const version = Buffer.alloc(1);
     version.writeUInt8(0);

tests/utils/stakingScript.test.ts

@@ -31,7 +31,7 @@ describe("stakingScript", () => {
       expect(() =>
         new StakingScriptData(
           pk1, // Staker Pk
-          [invalidPk], // Finality Provider Pks
+          [pk2, invalidPk], // Finality Provider Pks
           [pk3, pk4, pk5], // covenant Pks
           2,
           stakingTimeLock,
@@ -41,25 +41,26 @@ describe("stakingScript", () => {
       ).toThrow("Invalid script data provided");
     });
 
-    it("should fail if more than one finality providers", () => {
+    it("should throw if more than one finality providers when building data embed script", () => {
+      const script = new StakingScriptData(
+        pk1, // Staker Pk
+        [pk2, pk6], // More than one FP Pks
+        [pk3, pk4, pk5], // covenant Pks
+        2,
+        stakingTimeLock,
+        unbondingTimeLock,
+        magicBytes
+      );
       expect(() =>
-        new StakingScriptData(
-          pk1, // Staker Pk
-          [pk2, pk6], // More than one FP Pks
-          [pk3, pk4, pk5], // covenant Pks
-          2,
-          stakingTimeLock,
-          unbondingTimeLock,
-          magicBytes
-        )
-      ).toThrow("Invalid script data provided");
+        script.buildDataEmbedScript()
+      ).toThrow("Only a single finality provider key is supported");
     });
 
     it("should fail if a covenant emulator key is not 32 bytes", () => {
       expect(() =>
         new StakingScriptData(
           pk1, // Staker Pk
-          [pk2], // Finality Provider Pks
+          [pk2, pk3], // Finality Provider Pks
           [pk4, invalidPk, pk5], // covenant Pks
           2,
           stakingTimeLock,