Add method to arbitrary msg using bip322 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Jul 18, 2024
walletcontroller/client.go
Outdated
| } | ||
|
|
||
| if !txscript.IsPayToWitnessPubKeyHash(toSpend.TxOut[0].PkScript) { | ||
| return nil, fmt.Errorf("") |
| // To work properly: | ||
| // - wallet must be unlocked | ||
| // - address must be under wallet control | ||
| // - address must be native segwit address |
There was a problem hiding this comment.
Our system should also support taproot address, right? How can we deal with that?
There was a problem hiding this comment.
so for now, from what I understand, we cannot support them now as we are forced to use old version of bitcoind with legacy wallets. This is due to using DumpPrivateKey operation which is unsupported in later version.
So the road to support bip86 taproot addresses would be:
- remove
DumpPrivateKey - bump bitcoind to latest versions (v26+)
- start experimenting how to add support for those addresses
One note though, this is not super criticial as:
- native segwit addresses are most popular ones
- in my mind staker progam in the future will by default generate new address for new staking operation (new public key) and default generated address by
getnewaddressfunction is native segwit one.
There was a problem hiding this comment.
added issue to track this: #185
There was a problem hiding this comment.
Thanks for the explanation! It makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/babylonchain/pm/issues/48
One of the places where staker program dumps private key is when creating pop for Babylon:
btc-staker/staker/stakerapp.go
Line 1460 in 5ab83e6
To remove
DumPrivateKeyfunction pop needs to be created in some other way.Unfortunately, we cannot use https://developer.bitcoin.org/reference/rpc/signmessage.html bitcoind api as this does not work for native segwit addresses (only legacy ones which should be avoided) . See: bitcoin/bitcoin#10542
Fortunately, Babylon supports pop with bip322 signatures. This pr add necessary api to create such signature along with the test. Followup pr will switch creating pop to this functions