Swap usage of ClientInterface instead of Client
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babenkoivan
approved these changes
Sep 29, 2023
|
Hi @stevebauman, thank you for the PR. This makes total sense! As you've mentioned, this would require a new major version for this and dependent packages. As the change is pretty small, I'd avoid releasing a major version until we have bigger changes in I will keep it open for now and merge in the future, I hope this is fine 🙂 |
|
Ok sounds good @babenkoivan! Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Merged to the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps references to the Elasticsearch PHP package's
final Clientto its new v8.0ClientInterfaceso that different implementations, fakes, and mocks can be returned for a bit easier testing.This will likely require a new major version, but wanted to push it in case you're interested.
Let me know if you'd like anything changed. Thanks so much for your time! ❤️