More specific error message when github auth fails #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an issue with a clear problem statement.
NEIL_GITHUB_TOKEN
,neil dep upgrade
does nothing, then terminates with exit code 0 #237I have updated the CHANGELOG.md file with a description of the addressed issue.
I have considered whether I should add more tests covering the code I've changed.
Proposed solution
Invalid Github token error messages before this PR:
Invalid Github token error messages after this PR:
Other changes
NEIL_GITHUB_TOKEN
) into adef
in order to provide more specific error messagesError message formatting
Other error messages are printed with the first line not indented, and following lines indented:
I'm not sure whether this is the desired way to print errors, or if it's accidental, eg code indenting. Clarification welcome!