Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fetch latest stable slipset/deps-deploy, instead of hard-coding (#206)
* Fetch latest stable slipset/deps-deploy, instead of hard-coding This is a minor change, which removes the hard-coding of the `slipset/deps-deploy` version in the `build-alias` function. I have tested the change locally using `bbin`, and see that `neil add build` now uses `slipset/deps-deploy {:mvn/version "0.2.2}` * Fix: broken tests due to real-world changes The following tests were breaking before the changes in this commit: ``` FAIL in (latest-version-test) (dep_add_test.clj:9) expected: (= "1.11.1" (neil/latest-stable-mvn-version (quote org.clojure/clojure))) actual: (not (= "1.11.1" "1.11.2")) FAIL in (dep-upgrade-test-using-git-tags) (dep_upgrade_test.clj:71) deps can be added with --tag expected: (= "v2022.03.08" (:git/tag original)) actual: (not (= "v2022.03.08" "v2024.03.13")) FAIL in (dep-upgrade-test-using-git-tags) (dep_upgrade_test.clj:79) deps with :git/tag coords upgrade to latest tags expected: (= "v2022.03.08" (:git/tag original)) actual: (not (= "v2022.03.08" "v2024.03.13")) FAIL in (dep-upgrade-test-using-git-tags) (dep_upgrade_test.clj:84) deps with :git/tag coords upgrade to latest tags expected: (not= (:git/tag original) (:git/tag upgraded)) actual: (not (not= "v2024.03.13" "v2024.03.13")) ``` The reasons for this are: 1. The latest stable version of `org.clojure/clojure` is `1.11.2` 2. Running `git/find-github-tag 'clj-kondo/clj-kondo "v2022.03.08"` returns `nil`, which makes `neil` fetch the latest github tag instead. To fix this, we: 1. Bump the latest stable version for Clojure in tests to 1.11.2 2. Bump the tag version used for `clj-kondo/clj-kondo` to `v2024.03.13` (latest) in `dep add` tests. 3. Bump the tag version used for `clj-kondo/clj-kondo` to `v2024.03.05` (not latest, but exists) in `dep upgrade` tests.
- Loading branch information