-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bbin ls
prints human readable text
#54
Conversation
0b676fd
to
097f8ca
Compare
bbin ls
prints human readable textbbin ls
prints human readable text
Thanks for the PR. I'll take a look at this soon. |
Amended a fix for the lint-warnings (that failed the build). |
@eval @borkdude: It looks like we have some challenges with smaller screen widths. Here's what the new version looks like on my MacBook Air. We can try to fix this problem within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a solution for readable output when small screen widths and long URLs are involved.
After thinking about this a bit more, I wonder if we should replace the table with something simpler and more compact. For example, here's the output of
We could do something similar (the
Or a more extended version:
What do you think? |
Maybe we can have two commands like |
Maybe it would make sense to print like neil: in general the output if neil can be piped back into neil subcommands.
E.g.:
|
@borkdude: That sounds good to me. |
It sure is pretty |
@eval: When I split my terminal on my MacBook Air with my current font size, I get 71 characters horizontally. If we can get it to work without wrapping in 71 characters then I'm open to merging this PR in. This will require truncation since URLs are often much longer than 71 characters plus each column needs its own space. |
@rads thanks for reconsidering this PR. I added a truncate-fn that truncates urls from the middle, e.g. |
04be9c0
to
0a29342
Compare
@eval: I appreciate your patience so far. I'm planning to do a final review this week. I'll put the new functionality behind a flag until I release |
Please answer the following questions and leave the below in as part of your PR.
Example:
Feedback welcome.