Merge pull request #23 from dragon3/use-bufio-reader

lint/internal/policy/funcs/unix.go

@@ -3,6 +3,7 @@ package funcs
 import (
 	"bufio"
 	"fmt"
+	"io"
 	"regexp"
 	"strings"
 
@@ -27,15 +28,22 @@ var GrepFunc = function.New(&function.Spec{
 		pattern := args[0].AsString()
 		text := args[1].AsString()
 		var matches []string
-		in := strings.NewReader(text)
-		scanner := bufio.NewScanner(in)
-		for scanner.Scan() {
-			matched, err := regexp.MatchString(pattern, scanner.Text())
+
+		r := bufio.NewReader(strings.NewReader(text))
+		for {
+			l, err := r.ReadString('\n')
+			if err == io.EOF {
+				break
+			} else if err != nil {
+				return cty.NilVal, err
+			}
+			l = strings.TrimRight(l, "\n")
+			matched, err := regexp.MatchString(pattern, l)
 			if err != nil {
 				return cty.NilVal, err
 			}
 			if matched {
-				matches = append(matches, scanner.Text())
+				matches = append(matches, l)
 			}
 		}
 		return cty.StringVal(strings.Join(matches, "\n")), nil

lint/internal/policy/funcs/unix_test.go

@@ -1,11 +1,22 @@
 package funcs
 
 import (
+	"bufio"
+	"math/rand"
 	"testing"
 
 	"github.com/zclconf/go-cty/cty"
 )
 
+func RandomString(n int) string {
+	var letter = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789")
+	b := make([]rune, n)
+	for i := range b {
+		b[i] = letter[rand.Intn(len(letter))]
+	}
+	return string(b)
+}
+
 func TestGrep(t *testing.T) {
 	tests := map[string]struct {
 		Pattern cty.Value
@@ -22,6 +33,11 @@ func TestGrep(t *testing.T) {
 			cty.StringVal("test\nhogehoge\nfoo\nbar\n"),
 			cty.StringVal(""),
 		},
+		"MatchLongString": {
+			cty.StringVal("hoge"),
+			cty.StringVal(RandomString(bufio.MaxScanTokenSize) + "\nhogehoge\nfoo\nbar\nhogebaz\n" + RandomString(bufio.MaxScanTokenSize+1)),
+			cty.StringVal("hogehoge\nhogebaz"),
+		},
 	}
 
 	for name, test := range tests {