Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard method call #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wildcard method call #60

wants to merge 1 commit into from

Conversation

comick
Copy link

@comick comick commented Sep 22, 2012

Hi!
I'm working on some use cases when the availability of a method call is known only once the call has been triggered, so I've introduced the possibility to handle wildcard method calls (only server side) using the '*' character which is not valid for method names according to the XML-RPC standard. Unlike the standard callback, the wildcard handler takes two callbaks, one when the method is manageable, while the other (not found) when not. Sure, the code can describe the new behavior better. I've improved the example and added one test.

Thanks for the work on node-xmlrpc, hope this can help to improve it.

Michele.

@baalexander
Copy link
Owner

Thanks @comick for the pull request and test case!

I'll be taking a deeper look at the functionality in the next few days.

@baalexander
Copy link
Owner

I reviewed the code @comick. I think your issue comes from another issue brought up about how method calls are treated as events. I've started planning out 2.0 of xmlrpc, which should allow for a less hacky way to handle messages, including those not found (a wildcard handler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants