Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json import #33

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

dylan-chong
Copy link
Contributor

@dylan-chong dylan-chong commented Sep 28, 2023

image

Added JSON import/export page.

  • the user can paste in some json to set the ranges/board/tree config.
    • this is to allow external tools to generate the json for a quick input
  • the json is automatically updated whenever any range/board/tree config is changed. for easy export

requires #31 to be merged first, as this is branched off that
fixes b-inary/wasm-postflop#17

@dylan-chong
Copy link
Contributor Author

Currently, the added/removed lines is not quite well supported, as it does not validate those. What would you recommend we do about those?

@b-inary
Copy link
Owner

b-inary commented Oct 1, 2023

I am very sorry, but I do not have time to review this pull request and have decided not to merge it. It is well written from what I have skimmed, and should be a much appreciated contribution.

As for the added/removed lines, I improved input validation with commit d640a3b. This should make the program much less likely to crash.

@dylan-chong
Copy link
Contributor Author

Awesome, have rebased (and fixed a few bugs)

@dylan-chong dylan-chong marked this pull request as draft October 5, 2023 02:46
@dylan-chong
Copy link
Contributor Author

Marking as draft as there is a few type/lint niggles to fix

@dylan-chong
Copy link
Contributor Author

@b-inary I've finished fixing up the lint issues. No hurry to get this merged, but would appreciate the review if you ever get the time.

If you need me to test any particular scenarios, I'm happy to do that and document the results

@dylan-chong dylan-chong marked this pull request as ready for review November 11, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an import feature
2 participants