-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update0.3 #28
base: main
Are you sure you want to change the base?
Conversation
…o years of data at once
Hi Shawn We are still developing the bootstrapping framework. I have tested one example: denmark_cube <- process_cube(
system.file("extdata", "denmark_mammals_cube_eqdgc.csv", package="b3gbi"))
denmark_observed_richness_ts <- obs_richness_ts(
example_cube_1, first_year = 1980, level = "country", region = "Denmark")
plot(denmark_observed_richness_ts) I notice that the indicator value is each time lower than the lower confidence limit. I still see you plot the uncertainty around the loess smoother. This uncertainty is not correct and can be dropped Should we discuss this in december? |
What is bootstrapped depends on the indicator. Observed richness bootstraps all occurrences. But in some other cases it would be inefficient to do so.
Yes, there are two indicators where the confidence intervals do not work quite right, and observed richness is one of them. Richness is tricky because when you sample with replacement the richness is reduced. So there is bias in the confidence intervals. Some methods in the boot package create CIs that are too low, others overcorrect the bias and make it too high. I am still trying to work out what to do about it.
I am not clear on why this is incorrect? It is meant to be the uncertainty around the trend.
Yes, good idea. |
Ok, let's discuss it then
Yes, the intention is good, but it does not take into account the uncertainty on the indicators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
As discussed online, 2 changes are requested:
- visualising uncertainty for
plot_ts()
, see PR 0.3plot timeseries #30. We can discuss this further in this PR - remove bootstrapping for indicators where it does not work (e.g. species richness)
Calculate and plot confidence intervals for all indicators