Optimize the between filter class.

Using a single return statement in the accept() method as it is more efficient than using two return statements, and it avoids the need to evaluate the expression in the second return statement if the first return statement is evaluated to true. Signed-off-by: Sacha Telgenhof <[email protected]>
azuyalabs · Oct 22, 2023 · cedccb6 · cedccb6
1 parent eaeb1d3
commit cedccb6
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/Yasumi/Filters/BetweenFilter.php b/src/Yasumi/Filters/BetweenFilter.php
@@ -63,10 +63,8 @@ public function accept(): bool
     {
         $holiday = $this->getInnerIterator()->current()->format(self::DATE_FORMAT);
 
-        if ($this->equal) {
-            return $holiday >= $this->startDate && $holiday <= $this->endDate;
-        }
-
-        return $holiday > $this->startDate && $holiday < $this->endDate;
+        return $this->equal
+            ? $holiday >= $this->startDate && $holiday <= $this->endDate
+            : $holiday > $this->startDate && $holiday < $this->endDate;
     }
 }