Avoid silent exceptions by throwing a new one from the previous excep…

…tion. Signed-off-by: Sacha Telgenhof <[email protected]>
azuyalabs · Dec 4, 2023 · 151a477 · 151a477
1 parent d8a136b
commit 151a477
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/tests/Portugal/PortugueseRepublicDayTest.php b/tests/Portugal/PortugueseRepublicDayTest.php
@@ -76,6 +76,7 @@ public function testHolidayBeforeEstablishment(): void
                 $this->assertNotHoliday(self::REGION, self::HOLIDAY, $year);
             }
         } catch (\Exception $e) {
+            throw new \RuntimeException($e->getMessage(), $e->getCode(), $e);
         }
     }
 
@@ -91,6 +92,7 @@ public function testTranslation(): void
                 );
             }
         } catch (\Exception $e) {
+            throw new \RuntimeException($e->getMessage(), $e->getCode(), $e);
         }
     }
 
@@ -106,6 +108,7 @@ public function testHolidayType(): void
                 );
             }
         } catch (\Exception $e) {
+            throw new \RuntimeException($e->getMessage(), $e->getCode(), $e);
         }
     }
 

diff --git a/tests/USA/VeteransDayTest.php b/tests/USA/VeteransDayTest.php
@@ -105,12 +105,13 @@ public function testVeteransDayNameBefore1954(): void
     {
         try {
             $year = $this->generateRandomYear(self::ESTABLISHMENT_YEAR, 1953);
+
+            $holidays = Yasumi::create(self::REGION, $year);
+            $holiday = $holidays->getHoliday(self::HOLIDAY);
+            self::assertEquals('Armistice Day', $holiday->getName());
         } catch (\Exception $e) {
+            throw new \RuntimeException($e->getMessage(), $e->getCode(), $e);
         }
-
-        $holidays = Yasumi::create(self::REGION, $year);
-        $holiday = $holidays->getHoliday(self::HOLIDAY);
-        self::assertEquals('Armistice Day', $holiday->getName());
     }
 
     /**
@@ -122,12 +123,13 @@ public function testVeteransDayNameAfter1954(): void
     {
         try {
             $year = $this->generateRandomYear(1954);
+
+            $holidays = Yasumi::create(self::REGION, $year);
+            $holiday = $holidays->getHoliday(self::HOLIDAY);
+            self::assertEquals('Veterans Day', $holiday->getName());
         } catch (\Exception $e) {
+            throw new \RuntimeException($e->getMessage(), $e->getCode(), $e);
         }
-
-        $holidays = Yasumi::create(self::REGION, $year);
-        $holiday = $holidays->getHoliday(self::HOLIDAY);
-        self::assertEquals('Veterans Day', $holiday->getName());
     }
 
     /**