Skip to content

Commit

Permalink
Updated a test in ML SDK to adapt to the changed validation on FQDNs. (
Browse files Browse the repository at this point in the history
…Azure#37700)

- Given test case passed

Co-authored-by: Jing Li <[email protected]>
  • Loading branch information
u9009 and Jing Li authored Oct 11, 2024
1 parent d565c1a commit 6360803
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ managed_network:
service_resource_id: /subscriptions/0caf7ec9-615a-4491-bad8-64ce023324e1/resourceGroups/joharrin-sdk-tests/providers/Microsoft.Network/applicationGateways/mvnettestappgw
spark_enabled: false
subresource_target: appGwPrivateFrontendIpIPv4
fqdns: ["contoso.com", "contoso2.com"]
fqdns: ["test.1.fake.com", "test.2.fake.com"]
type: private_endpoint
tags: {}
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
from devtools_testutils import AzureRecordedTestCase, is_live

from azure.ai.ml import MLClient, load_workspace
from azure.ai.ml.entities._workspace.workspace import Workspace
from azure.ai.ml.constants._workspace import IsolationMode, OutboundRuleCategory
from azure.ai.ml.entities._workspace.networking import (
FqdnDestination,
ManagedNetwork,
PrivateEndpointDestination,
ServiceTagDestination,
)
from azure.ai.ml.constants._workspace import IsolationMode, OutboundRuleCategory
from azure.ai.ml.entities._workspace.workspace import Workspace
from azure.core.polling import LROPoller


Expand Down Expand Up @@ -100,8 +100,8 @@ def test_workspace_create_with_managed_network_list_show_remove_rules(
assert "applicationGateways/mvnettestappgw" in app_gw_pe_rule.service_resource_id
assert app_gw_pe_rule.spark_enabled == False
assert app_gw_pe_rule.subresource_target == "appGwPrivateFrontendIpIPv4"
assert "contoso.com" in app_gw_pe_rule.fqdns
assert "contoso2.com" in app_gw_pe_rule.fqdns
assert "test.1.fake.com" in app_gw_pe_rule.fqdns
assert "test.2.fake.com" in app_gw_pe_rule.fqdns

# test adding outbound rules with workspace update from yaml
params_override = [
Expand Down

0 comments on commit 6360803

Please sign in to comment.