Skip to content

Commit

Permalink
[engsys] inline eslint step into analyze template (Azure#32304)
Browse files Browse the repository at this point in the history
### Packages impacted by this PR

None directly, this only touches CI.

### Describe the problem that is addressed by this PR

We were seeing odd behavior in CI where the `rush install` inside of the
lint step was failing, but since this task was only ever called from
analyze, which has already executed `rush install` it seemed
unnecessary.

This change inlines the behavior from the run-estlint step and avoids
the duplicate `rush install` call.
  • Loading branch information
xirzec authored Dec 19, 2024
1 parent a65d4ad commit c5e8d31
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 15 deletions.
7 changes: 4 additions & 3 deletions eng/pipelines/templates/steps/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,10 @@ steps:
node eng/tools/rush-runner/index.js build $(ChangedServices) -packages "$(ArtifactPackageNames)" --verbose -p max
displayName: "Build libraries"
- template: /eng/pipelines/templates/steps/run-eslint.yml
parameters:
ServiceDirectories: $(ChangedServices)
- pwsh: |
node common/scripts/install-run-rush.js build -t @azure/eslint-plugin-azure-sdk -t @azure/monitor-opentelemetry-exporter
node eng/tools/rush-runner/index.js lint "$(ChangedServices)" -p max
displayName: "Build ESLint Plugin and Lint Libraries"
- pwsh: |
node eng/tools/rush-runner/index.js check-format $(ChangedServices) -packages "$(ArtifactPackageNames)" --verbose
Expand Down
12 changes: 0 additions & 12 deletions eng/pipelines/templates/steps/run-eslint.yml

This file was deleted.

0 comments on commit c5e8d31

Please sign in to comment.