-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core/DB): port WarheadCore database #16659
Conversation
1a1b9e1
to
8c8663b
Compare
8c8663b
to
cd033b2
Compare
What is the benefit for this? |
Performance. And now can make new db in modules (need test anyway) :D |
We love performance 😎 |
Everyone loves it, but it takes a lot of testing. |
Now this is cool |
That should be documented though imo |
Absolutely, have to test everything first. |
Modules gonna need updating. 😬 |
yes yes |
Update modules |
I understand that this might exceed the current scope, and it's more like my stream of consciousness. But if we could connect to multiple character databases, bind them to players, and incorporate PR with clustering support, we might be close to a cross-realm implementation. |
Status? |
Need time :D |
Please reopen when continue |
Changes Proposed:
PreparedStatement
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
Deps modules
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.