Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary grace period #117

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add temporary grace period #117

merged 2 commits into from
Jul 24, 2024

Conversation

realnimish
Copy link
Member

Domains with expiry earlier than grace-timestamp will remain valid (and fully functional) till the grace-timestamp.

Grace timestamp currently hard-coded to 1st Oct 2024 00:00 UTC

wottpal
wottpal previously approved these changes Jul 20, 2024
Copy link
Member

@wottpal wottpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. After finishing the test, feel free to merge, and rebase #113! :)

@realnimish realnimish marked this pull request as ready for review July 23, 2024 09:53
@realnimish realnimish requested a review from wottpal July 23, 2024 09:53
@realnimish realnimish merged commit 9b199a3 into develop Jul 24, 2024
2 checks passed
@realnimish realnimish deleted the feat/add-temp-grace-period branch July 24, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants