-
Notifications
You must be signed in to change notification settings - Fork 0
Style Maps & add regional organization design pass #1342
Conversation
Okay, I made the above changes where I could, and some additional ones after crit. Ready for another look.
|
c81f736
to
7c1a235
Compare
@alexelash This has been rebased on the latest One thing I wasn't sure about was whether to include some of the changes to the Map page in the newly added Map modal. It didn't make sense to me to include the "Maps" Should be easy to selectively hide it on the map modal if that's what you'd prefer. |
@maurizi Good call. I think the rest of the text is useful at the moment, since we don't yet have specific text for each data viz. Once we have that, it may not be necessary. But I imagine I'll also need to do a style pass of the modals anyway, so can consider removing it then. |
This all looks good. Here are just a few comments:
|
Adding a |
We're using the "Absolute threshold: 0.01 inches" option for this layer, which was why I dropped the "Extreme" from the layer title - but I'll defer to @jcahail on putting it back in. |
Merging without Jess's comments for now due to issues with VM and a desire to get these changes up sooner. Those will be fixed in #1345 |
Overview
The Maps page had been added to Temperate, and this PR is a design pass for the new features. At the same time, I made some minor adjustments to Create Org, Create Plan, and Dashboard.
Demo
Create organization region
Dashboard
Maps
Notes
General:
Future work:
null
option within the<select>
input. This will be covered in Ensure that a visualization is always selected for maps #1340.Questions:
We have these attributions, do you have any changes you'd like me to make?
Testing Instructions
To see all the possiblities on the map page, you will need one with a valid city location, and one with an AOI selection. Ensure that the locations are within California to see all of the maps.