Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Style Maps & add regional organization design pass #1342

Merged
merged 14 commits into from
Nov 21, 2019

Conversation

alexelash
Copy link
Contributor

Overview

The Maps page had been added to Temperate, and this PR is a design pass for the new features. At the same time, I made some minor adjustments to Create Org, Create Plan, and Dashboard.

Demo

Create organization region
Screen Shot 2019-11-08 at 1 55 02 PM
Screen Shot 2019-11-08 at 1 55 19 PM
Screen Shot 2019-11-08 at 1 55 06 PM

Dashboard
Screen Shot 2019-11-08 at 1 40 28 PM
Screen Shot 2019-11-08 at 1 55 47 PM

Maps
Screen Shot 2019-11-08 at 1 40 02 PM
Screen Shot 2019-11-08 at 1 39 30 PM
Screen Shot 2019-11-08 at 1 39 06 PM
Screen Shot 2019-11-08 at 2 03 02 PM

Notes

General:

  • The only data colors I wanted to change were the ones we can't... the Fires one 😢Unless there's a good reason to change the CalEnviro ones (@jcahail let me know!) I like them and think they're appropriate.
  • Once the footer is gone, the map will always be 100% height of the screen, and the sidebar will scroll (see Don't show footer on some pages #1330).

Future work:

  • I moved the "About this map" link lower on the page, since we plan to add a 1 sentence description under the visualization input. When we do this, we may want to change this and have a "Learn more" link after the description.
  • We will want to remove the null option within the <select> input. This will be covered in Ensure that a visualization is always selected for maps #1340.
  • We will want the footer to be removed, in order to preserve vertical space. This will be covered in Don't show footer on some pages #1330.

Questions:

  • I couldn't figure out how to style the overlay + outline of the user's region on the map, but I would like to. I could use help with this @maurizi
  • Mike and I have an open conversation about the attributions and their respective URLs, but this may be a better question for @jcahail:

We have these attributions, do you have any changes you'd like me to make?

  1. Air Quality: Ozone - CalEnviroScreen 3.0
  2. Air Quality: PM2 - CalEnviroScreen 3.0
  3. Drinking Water Contaminants - CalEnviroScreen 3.0
  4. Number of Precipitation Days - CDC NEPHT, accessed Oct 7, 2019, link ?
  5. Wildfire Hazard Potential - Rocky Mountain Research Station

Testing Instructions

To see all the possiblities on the map page, you will need one with a valid city location, and one with an AOI selection. Ensure that the locations are within California to see all of the maps.

@alexelash
Copy link
Contributor Author

Okay, I made the above changes where I could, and some additional ones after crit. Ready for another look.

  • Moved zoom controls to the right
  • Made the map marker a little smaller and less noticeable (it was noted that it feels like it's blocking the content below, and there were some interesting ideas to mitigate this... for now just made it smaller and a less poppy color).

Screen Shot 2019-11-11 at 2 21 16 PM

- Changed may layer colors to be a single hue, per advice that it will likely be easier to interpret. Darker is supposed to be "worse", as the basemap is overall light so the eye goes to darker colors. Would like confirmation on my assumptions for what's worse @jcahail, maybe we could screenshare to discuss... Air Quality: PM2.5 in particular is confusing to me. - I noticed that there are no units shown at the moment, and didn't see an issue for it. I created this one to cover this work: https://github.com//issues/1346 - I also noticed this strange issue with one of the legends, and I'm not sure how to resolve it (the highest should be at the bottom):

Screen Shot 2019-11-11 at 2 01 34 PM

Oddly enough, swatch colors don't seem to be out of order. Any ideas?

@alexelash alexelash changed the title WIP: Style Maps & add regional organization design pass Style Maps & add regional organization design pass Nov 12, 2019
@maurizi
Copy link
Contributor

maurizi commented Nov 14, 2019

@alexelash This has been rebased on the latest develop.

One thing I wasn't sure about was whether to include some of the changes to the Map page in the newly added Map modal. It didn't make sense to me to include the "Maps" <h1> element, right below "Maps on X" in the modal header, but I wasn't sure if I should similarly exclude the new copy above the Visualizations <select>:
image

Should be easy to selectively hide it on the map modal if that's what you'd prefer.

@alexelash
Copy link
Contributor Author

@maurizi Good call. I think the rest of the text is useful at the moment, since we don't yet have specific text for each data viz. Once we have that, it may not be necessary. But I imagine I'll also need to do a style pass of the modals anyway, so can consider removing it then.

@jcahail
Copy link

jcahail commented Nov 15, 2019

This all looks good. Here are just a few comments:

@maurizi
Copy link
Contributor

maurizi commented Nov 15, 2019

Adding a % unit will require a code change - we can tackle that as part of #1346

@maurizi
Copy link
Contributor

maurizi commented Nov 15, 2019

Can we fit "Number of Extreme Precipitation Days" as the title for the CDC NEPHT layer? Extreme is actually the key part there. This link should take you to the layer in question: https://ephtracking.cdc.gov/DataExplorer/?query=3aed3f15-8c65-4569-b714-e70b4f905fcf#/.

We're using the "Absolute threshold: 0.01 inches" option for this layer, which was why I dropped the "Extreme" from the layer title - but I'll defer to @jcahail on putting it back in.

@alexelash
Copy link
Contributor Author

@jcahail & @maurizi -- the percentage or "percentile" appears next to the header in the wireframes. We can talk about it while work is completed for #1346, but that was the original plan.

@alexelash
Copy link
Contributor Author

Merging without Jess's comments for now due to issues with VM and a desire to get these changes up sooner. Those will be fixed in #1345

@alexelash alexelash merged commit 9af2698 into develop Nov 21, 2019
@maurizi maurizi deleted the feature/al/map-styles branch December 6, 2019 19:15
@maurizi maurizi restored the feature/al/map-styles branch December 6, 2019 19:16
@maurizi maurizi deleted the feature/al/map-styles branch December 6, 2019 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants