Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Overpass epoch offset for adiff seq id #44

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

CloudNiner
Copy link
Contributor

As described at:
https://wiki.openstreetmap.org/wiki/Overpass_API/Augmented_Diffs#Time_slices_and_numbering

Now we generate the correct diff seq id for the end timestamp of the diff:

OSM Change Sequence Id 4199848 @ 2020-09-17 18:48:03+00:00 -> Minutely Augmented Diff Id 4215592
Augmented Diff written to: Bucket <bucket>, Path: onramp-diffs/004/215/592.xml.gz (gzip=True)
Augmented diff 4215592 generated in 2.12628436088562s
Committed: 4199847 -> 4199848 in 0.054 seconds.

If I pull the Overpass diff for the same sequence, I now get mostly the same elements as in the Onramp diff:

4215592.zip

Closes #41

@CloudNiner
Copy link
Contributor Author

CloudNiner commented Sep 22, 2020

I think the original bug here was because I pulled the seq id to timestamp formula from https://github.com/geotrellis/vectorpipe. I've opened an issue there as well geotrellis/vectorpipe#142

@CloudNiner CloudNiner merged commit dd0818a into master Sep 22, 2020
@CloudNiner CloudNiner deleted the fixup/awf/sequence-offset#41 branch September 22, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augmented diff sequence IDs are off by one
1 participant