Openaiwrapper memoize #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edding and chat_completion functions
|
Hi @bearney74, it’s great to see a first contribution! I truly appreciate the time and effort you have invested in this work. You have made some fantastic improvements, particularly with the use of memoize to cache embedding calls across runs. Thank you very much! 🚀🚀🚀 |
aymenfurter
requested changes
Dec 24, 2023
aymenfurter
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add memoize so that we can cache the results from openaiAPIWrapper.
move the parsing logic into the chat_completion function from the various functions that call it.
move the model we use into the chat_completion function so that we can easily change it if we need to.
#remove date and time from prompts so that we can cache the results we get from openai.