Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix this issue https://github.com/ayeo-flex-org/pulsar-flex/issues/90… #91

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

geoffhendrey
Copy link
Contributor

…. Closes underlying socket and dangling timeout

@geoffhendrey
Copy link
Contributor Author

geoffhendrey commented Nov 2, 2024

ping @galrose -- is this a problem with the test suite? The tests ran fine on my local machine. It appears docker-compose isn't found in CI? I see the following error at the start of the CI tests.

Creating pulsar via docker-compose from path /home/runner/work/pulsar-flex/pulsar-flex/scripts/docker/pulsar-jwt/2.8.0/docker-compose.yml
Waiting 60000ms for pulsar-standalone to start before creating configurations
docker-compose killed Error: Command failed: docker-compose -f /home/runner/work/pulsar-flex/pulsar-flex/scripts/docker/pulsar-jwt/2.8.0/docker-compose.yml up --build
/bin/sh: 1: docker-compose: not found

Validating pulsar is up still up after waiting
(node:[17](https://github.com/ayeo-flex-org/pulsar-flex/actions/runs/11614750705/job/32349230459#step:5:18)84) UnhandledPromiseRejectionWarning: Error: pulsar-standalone-pulsar-flexhas been closed, tests setup aborted - maybe try to increase wait standaloneWaitTime
    at /home/runner/work/pulsar-flex/pulsar-flex/scripts/test-setup.js:52:11

@danielsinai
Copy link
Collaborator

Hi @geoffhendrey
Getting back to you, it seems like your PR is not relevant to the problems and something in the CI broke.

If you don't mind I will fix it sometime this weekend/next week and then I will ask you to pull this changes so the CI will pass

@geoffhendrey
Copy link
Contributor Author

@danielsinai thank you very much!

@danielsinai
Copy link
Collaborator

No problem @geoffhendrey
Just fixed the issue #92 with the CI feel free to pull from main, rerun your tests and I will approve the PR 👍

@geoffhendrey
Copy link
Contributor Author

@danielsinai merged main into my branch, all tests pass locally. You may need to approve the workflow to run the tests for this PR.

@geoffhendrey
Copy link
Contributor Author

@danielsinai I do not have permissions to merge. Can you merge this PR?

@danielsinai danielsinai merged commit 8509ae2 into ayeo-flex-org:main Dec 28, 2024
1 check passed
@danielsinai
Copy link
Collaborator

Done @geoffhendrey thx for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants