Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert classes to Swift 3 #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Sep 19, 2016

I converted the main classes to work with Swift 3. This helps when using the classes as-is like I do in my project BartyCrouch.

I recommend you to merge this into a new "swift3" branch and note its existence in the master branch. This way people can check it out and use the classes as is (I integrate them with Carthage but link them manually from the Carthage/Checkouts folder).

From there you can improve everything to work with Swift 3 and Xcode 8.

@menzow
Copy link

menzow commented Jul 6, 2017

Hey @Dschee ,

I added a PR Jeehut#1 on your forks master branch per your request here: FlineDev/BartyCrouch#59.

I think this build is failing because your xcworkspace isn't being re-created by travis. I think The sample project was renamed or something by @ayanonagon. Adding the following changes should fix the broken build:

Podfile

target "PolyglotSample" do
  pod 'Polyglot', :path => '.' # Don't think this line is required.
end

Replace the test run instruction in .travis with:

- set -o pipefail && xcodebuild -workspace PolyglotSample.xcworkspace -scheme PolyglotSample -sdk iphonesimulator9.1 test | xcpretty -c

If iphonesimulator9.1 isn't available you could try iphonesimulator10.3.

Kind regards,
Menzo.

@Datoto1205
Copy link

It couldn't work in swift 3 & Xcode 8...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants