Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): hl-Statusline retrieval issue in toggleterm #1381

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Jint-lzxy
Copy link
Collaborator

This commit should fix a weird bug where nvim_get_hl would return an empty dict when trying to get hl-Statusline inside toggleterm. Not 100% sure why this was happening or what exact conditions caused it, but with this fix lualine now shows the right backgrounds in terminal mode!

  • Before (notice that eg the git section doesn't have proper guibg):
    before
  • After:
    after

This commit should fix a weird bug where `nvim_get_hl` would return an empty
dict when trying to get `hl-Statusline` inside `toggleterm`. Not 100% sure why
this was happening or what exact conditions caused it, but with this fix lualine
now shows the right backgrounds in terminal mode!

Signed-off-by: Jint-lzxy <[email protected]>
Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure its influence but LGTM.

@ayamir ayamir merged commit 7acd22d into ayamir:main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants