Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use aerial to provide outline. #1059

Merged
merged 8 commits into from
Nov 11, 2023
Merged

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Nov 9, 2023

Aerial.nvim has better outline support than symbols-outline.nvim. #1058 will be solved.

@ayamir ayamir linked an issue Nov 9, 2023 that may be closed by this pull request
3 tasks
@ayamir
Copy link
Owner Author

ayamir commented Nov 9, 2023

image

image

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Nov 9, 2023

the keymaps in the aerial config doesn't seem to work.
it works, my skill issue lol

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Nov 9, 2023

i think aerial's telescope extension is so spot on that I think we should just change keymap:go to open it's telescope preview.
How do u think? @ayamir @Jint-lzxy
image

@Jint-lzxy
Copy link
Collaborator

also i think aerial's telescope extension is so spot on that I think we should just change keymap:go to open it's telescope preview. How do u think?

Agree, but why not assign a keymap to each of them lol

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Nov 9, 2023

Agree, but why not assign a keymap to each of them lol

absolutely! that would be even better!

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Nov 9, 2023

I think it good to go.

@Jint-lzxy
Copy link
Collaborator

Sorry I'm a bit busy with other stuff atm. I'll review this PR sometime tomorrow :D

Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍯 but we probably need to update the relevant parts of the wiki before merging this lol

@CharlesChiuGit CharlesChiuGit merged commit 8b51185 into main Nov 11, 2023
4 checks passed
@CharlesChiuGit CharlesChiuGit deleted the refactor/use-aerial branch November 11, 2023 06:42
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Nov 27, 2023
* refactor: use aerial to provide outline.

Signed-off-by: ayamir <[email protected]>

* chore(aerial): update filter symbols

* chore(aerial): cleaner syntax tree

* feat(aerial): add telescope support

* fix(aerial): empty aerial telescope preview

* feat(keymap): add `gto` keymap for `:Telescope aerial`

* chore: cleanup

* chore(aerial): prune default options from setup func

---------

Signed-off-by: ayamir <[email protected]>
Co-authored-by: CharlesChiuGit <[email protected]>
Co-authored-by: Jint-lzxy <[email protected]>
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Dec 13, 2023
* refactor: use aerial to provide outline.

Signed-off-by: ayamir <[email protected]>

* chore(aerial): update filter symbols

* chore(aerial): cleaner syntax tree

* feat(aerial): add telescope support

* fix(aerial): empty aerial telescope preview

* feat(keymap): add `gto` keymap for `:Telescope aerial`

* chore: cleanup

* chore(aerial): prune default options from setup func

---------

Signed-off-by: ayamir <[email protected]>
Co-authored-by: CharlesChiuGit <[email protected]>
Co-authored-by: Jint-lzxy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol outline doesn't work properly in python files and C files
3 participants