Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppeteer update #187

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Puppeteer update #187

merged 2 commits into from
Sep 23, 2024

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Sep 23, 2024 •
edited
Loading

  • Update puppeteer to 20.0.2 to generate match reports as PDF
  • ReportSheetCache can switch between Puppeteer and Chromium command line to generate PDFs
  • Create ReportSheetCache instance with ILoggerFactory
  • Note: Puppeteer can currently create PDF files only with Chrome

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@axunonb axunonb merged commit 7ae765c into main Sep 23, 2024
4 checks passed
@axunonb axunonb deleted the pr/puppeteer-update branch September 23, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axunonb