Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge comparer classes into one class RankComparer #115

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Merge comparer classes into one class RankComparer #115

merged 4 commits into from
Sep 17, 2023

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Sep 17, 2023

RankComparer can now handle the following rules to build ranking tables:

  • LegacyRankComparer: The rules Augsburg volleyball leagues until August 2023 for 2 or 3 winning set matches (depending on season)
  • TwoWinningSetsRankComparer: The rules of Bavarian Volleyball Association (BVV) as of 2020-06-19 for 2 winning set matches.
  • ThreeWinningSetsRankComparer: The rules of German Volleyball National League (DVV), in use since season 2013/14 for 3 winning set matches, and applying the 3-point rule.
  • HroThreeWinningSetsRankComparer: The rules of the Volleyball-Stadtliga Rostock, starting with season 2023/24 for 3 winning set matches, and applying the 3-point rule.

Refactor RankComparer and Ranking:

  • Change RankComparerEnum to RankComparison enum
  • Remove double initialization of Rank properties
  • Add property RankComparison to IRankComparer
  • Remove setters from properties of type PointResult
  • RankComparer.Ranking is not nullable
  • Fix initialization of RankingChart.GraphBackgroundColorArgb and RankingChart.PlotAreaBackgroundColorArgb
  • RankingTeamHistory: Remove parameterless constructor
  • Add unit tests: Increase coverage of namespace TournamentManager.Ranking to 93%

Bump version to v6.6.0

@axunonb
Merge comparers into one class RankComparer
7dee9b7 
* Change RanComparerEnum to RankComparison enum
* Remove double initialization of Rank properties
@axunonb
Complete refactoring of RankComparer and Ranking
bedd0b4 
* Add property RankComparison to IRankComparer
* Remove setters from all PointResult properties
* RankComparer.Ranking is not nullable
* Fix initialization of RankingChart.GraphBackgroundColorArgb and RankingChart.PlotAreaBackgroundColorArgb
* RankingTeamHistory: Remove parameterless constructor
Add unit tests. TournamentManager.Ranking now has 93% coverage

Bump version to v6.6.0
@axunonb
Add description for LegacyRankComparer
6c172e7
@axunonb
Correct description for HroThreeWinningSetsRankComparer
33c5a48
@axunonb axunonb merged commit 274314e into main Sep 17, 2023
3 checks passed
@axunonb axunonb deleted the pr/refactor-ranking branch September 17, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axunonb