Skip to content

Commit

Permalink
SonarCloud recommendations
Browse files Browse the repository at this point in the history
  • Loading branch information
axunonb committed Sep 29, 2024
1 parent 32de102 commit 4962469
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion League/Caching/ReportSheetCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public async Task<Stream> GetOrCreatePdf(MatchReportSheetRow data, string html,
return stream;
}

private bool IsOutdated(string cacheFile, DateTime dataModifiedOn)
private static bool IsOutdated(string cacheFile, DateTime dataModifiedOn)
{
var fi = new FileInfo(cacheFile);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ private void EnsureTempFolder(string tempFolder)
public async Task<byte[]?> GeneratePdfData(FileInfo htmlFile, CancellationToken cancellationToken)
{
var pdfData = UsePuppeteer
? await GetPdfDataPuppeteer(htmlFile, cancellationToken)
? await GetPdfDataPuppeteer(htmlFile)
: await GetPdfDataBrowser(htmlFile, cancellationToken);

return pdfData;
Expand Down Expand Up @@ -112,7 +112,7 @@ private void EnsureTempFolder(string tempFolder)
}
}

private async Task<byte[]?> GetPdfDataPuppeteer(FileInfo fileInfo, CancellationToken cancellationToken)
private async Task<byte[]?> GetPdfDataPuppeteer(FileInfo fileInfo)
{
return await GetPdfDataPuppeteer(fileInfo.FullName, true);
}
Expand Down

0 comments on commit 4962469

Please sign in to comment.