-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XIVY-10541 Detect different plugin versions #543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 18, 2024 13:25
240c279
to
f7905cf
Compare
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 18, 2024 14:02
2baaaee
to
9d437ab
Compare
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 18, 2024 14:06
9d437ab
to
b2a4970
Compare
ivy-rew
reviewed
Dec 18, 2024
ivy-rew
reviewed
Dec 18, 2024
ivy-rew
reviewed
Dec 18, 2024
ivy-rew
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach a lot 🤩 ... some bikeshed comments :)
ivy-rew
reviewed
Dec 18, 2024
New error output:
|
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 18, 2024 14:55
9449010
to
4044c9a
Compare
ivy-lli
changed the title
Validate different versions
XIVY-10541 Detect different plugin versions and throw error
Dec 18, 2024
ivy-lli
changed the title
XIVY-10541 Detect different plugin versions and throw error
XIVY-10541 Detect different plugin versions
Dec 18, 2024
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 18, 2024 14:55
4044c9a
to
1a3f0d6
Compare
ivy-rew
approved these changes
Dec 18, 2024
ivy-rew
reviewed
Dec 18, 2024
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 18, 2024 15:09
1a3f0d6
to
18aa4f5
Compare
👍 |
ivy-lli
force-pushed
the
validate-different-versions
branch
from
December 19, 2024 07:15
18aa4f5
to
5d64508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with different project-build-plugin versions (12.0.1 and 12.0.2). Result in error message:
Tested also with same project-build-plugin version but different engine versions (12.0.0 and 12.0.1). With this the build was successful.