Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XIVY-10541 Detect different plugin versions #543

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ivy-lli
Copy link
Member

@ivy-lli ivy-lli commented Dec 18, 2024

Tested with different project-build-plugin versions (12.0.1 and 12.0.2). Result in error message:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] workflow-demos                                                     [iar]
[INFO] workflow-demos-test                               [iar-integration-test]
[INFO] workflow-demos-product                                             [pom]
[INFO] workflow-modules                                                   [pom]
[INFO]
[INFO] ------------------< com.axonivy.demo:workflow-demos >-------------------
[INFO] Building workflow-demos 12.0.2-SNAPSHOT                            [1/4]
[INFO]   from workflow-demos/pom.xml
[INFO] --------------------------------[ iar ]---------------------------------
Downloading from central.snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/maven/plugins/maven-surefire-plugin/maven-metadata.xml
[INFO]
[INFO] --- ivy:12.0.2-SNAPSHOT:maven-dependency-cleanup (default-maven-dependency-cleanup) @ workflow-demos ---
[INFO] Deleting /Users/lli/GitWorkspace/market/demo-projects/workflow/workflow-demos/lib/mvn-deps
[INFO]
[INFO] --- clean:3.2.0:clean (default-clean) @ workflow-demos ---
[INFO] Deleting /Users/lli/GitWorkspace/market/demo-projects/workflow/workflow-demos/target
[INFO]
[INFO] --- ivy:12.0.2-SNAPSHOT:validate (default-validate) @ workflow-demos ---
[ERROR] Several versions of project-build-plugins are configured [12.0.1-SNAPSHOT, 12.0.2-SNAPSHOT]:
[ERROR] 12.0.1-SNAPSHOT:
[ERROR] 	MavenProject: com.axonivy.demo:workflow-demos-test:12.0.2-SNAPSHOT @ /Users/lli/GitWorkspace/market/demo-projects/workflow/workflow-demos-test/pom.xml
[ERROR] 12.0.2-SNAPSHOT:
[ERROR] 	MavenProject: com.axonivy.demo:workflow-demos:12.0.2-SNAPSHOT @ /Users/lli/GitWorkspace/market/demo-projects/workflow/workflow-demos/pom.xml
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for workflow-modules 12.0.2-SNAPSHOT:
[INFO]
[INFO] workflow-demos ..................................... FAILURE [  0.192 s]
[INFO] workflow-demos-test ................................ SKIPPED
[INFO] workflow-demos-product ............................. SKIPPED
[INFO] workflow-modules ................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.222 s
[INFO] Finished at: 2024-12-18T14:59:23+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.axonivy.ivy.ci:project-build-plugin:12.0.2-SNAPSHOT:validate (default-validate) on project workflow-demos: All project-build-plugins configured in one reactor must use the same version -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Tested also with same project-build-plugin version but different engine versions (12.0.0 and 12.0.1). With this the build was successful.

@ivy-lli ivy-lli changed the base branch from master to release/12.0 December 18, 2024 13:00
@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 240c279 to f7905cf Compare December 18, 2024 13:25
@ivy-lli ivy-lli requested review from ivy-rew and removed request for ivy-rew December 18, 2024 13:59
@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 2baaaee to 9d437ab Compare December 18, 2024 14:02
@ivy-lli ivy-lli marked this pull request as ready for review December 18, 2024 14:02
@ivy-lli ivy-lli requested a review from ivy-rew December 18, 2024 14:02
@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 9d437ab to b2a4970 Compare December 18, 2024 14:06
Copy link
Member

@ivy-rew ivy-rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach a lot 🤩 ... some bikeshed comments :)

@ivy-lli
Copy link
Member Author

ivy-lli commented Dec 18, 2024

New error output:

[INFO] --- ivy:12.0.2-SNAPSHOT:validate (default-validate) @ workflow-demos ---
[ERROR] Several versions of project-build-plugins are configured [12.0.1-SNAPSHOT, 12.0.2-SNAPSHOT]:
12.0.1-SNAPSHOT -> [workflow-demos-test]
12.0.2-SNAPSHOT -> [workflow-demos]

@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 9449010 to 4044c9a Compare December 18, 2024 14:55
@ivy-lli ivy-lli changed the title Validate different versions XIVY-10541 Detect different plugin versions and throw error Dec 18, 2024
@ivy-lli ivy-lli changed the title XIVY-10541 Detect different plugin versions and throw error XIVY-10541 Detect different plugin versions Dec 18, 2024
@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 4044c9a to 1a3f0d6 Compare December 18, 2024 14:55
@ivy-lli ivy-lli requested a review from ivy-rew December 18, 2024 14:57
@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 1a3f0d6 to 18aa4f5 Compare December 18, 2024 15:09
@ivy-rew
Copy link
Member

ivy-rew commented Dec 18, 2024

👍

@ivy-lli ivy-lli force-pushed the validate-different-versions branch from 18aa4f5 to 5d64508 Compare December 19, 2024 07:15
@ivy-lli ivy-lli merged commit 09aaa8a into release/12.0 Dec 19, 2024
3 of 5 checks passed
@ivy-lli ivy-lli deleted the validate-different-versions branch December 19, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants