Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-626 Fix for Dev Fail on Market-Monitor #34

Merged

Conversation

phhung-axonivy
Copy link
Contributor

No description provided.

@phhung-axonivy phhung-axonivy requested a review from ivy-rew July 30, 2024 03:48
@ivy-rew
Copy link
Member

ivy-rew commented Jul 30, 2024

looks like we must 'enableWebServer=true' for the failing test

@phhung-axonivy
Copy link
Contributor Author

looks like we must 'enableWebServer=true' for the failing test

Hi @ivy-rew
I added 'enableWebServer=true' but the test still fails. I report this issue to @nqhoan-axonivy and he will check it later.

@ivy-rew
Copy link
Member

ivy-rew commented Jul 30, 2024

looks like we must 'enableWebServer=true' for the failing test

Hi @ivy-rew I added 'enableWebServer=true' but the test still fails. I report this issue to @nqhoan-axonivy and he will check it later.

Ok, I quickly checked the code; it seems as if the 'restClient' by name resolution is not wise, since it contains special characters.
I think you just have to change the test-setup to lookup the client by ID:
UUID: c700c640-4f76-4cbe-8724-dbc663d8bc0a

…nnector into feature/MARP-626-Fix-for-Dev-Fail-on-Market-Monitor
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test Results

2 tests  ±0   2 ✅ ±0   10s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5945980. ± Comparison against base commit 65f7206.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test Results

2 tests  ±0   2 ✅ ±0   9s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5945980. ± Comparison against base commit 65f7206.

@phhung-axonivy
Copy link
Contributor Author

Hi @ivy-rew
@nqhoan-axonivy fixed the test.
Could you please approve this PR?

Copy link
Contributor

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phhung-axonivy phhung-axonivy merged commit 116c6bf into master Aug 2, 2024
3 checks passed
@phhung-axonivy phhung-axonivy deleted the feature/MARP-626-Fix-for-Dev-Fail-on-Market-Monitor branch August 2, 2024 05:21
@ivy-rew
Copy link
Member

ivy-rew commented Aug 2, 2024

🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants