Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation - Threema Connector #2

Merged
merged 77 commits into from
Oct 20, 2023
Merged

Implementation - Threema Connector #2

merged 77 commits into from
Oct 20, 2023

Conversation

ivy-fhe
Copy link
Contributor

@ivy-fhe ivy-fhe commented Oct 20, 2023

Initial Implementation of the Threema Connector, passing all builds.

ivy-fhe and others added 30 commits October 4, 2023 11:35
@ivy-fhe
Update pom.xml
51a27ee 
Specified product name
@ivy-fhe
initial project creation for threema-connector
cd52aa3
@ivy-fhe
initial implementation of message handler
46374e2 
enables keygeneration and message encryption
@ivy-fhe
initial draft of ApiConnector
b7717f4
@ivy-fhe
added threema-msgapi-tool.jar
da08f90
@ivy-fhe
added resource folder
724e177
@ivy-fhe
fixed format to match axonivy standard
853e56c
@ivy-fhe
added first implementation of property helper
721426e
@ivy-fhe
Downgraded from 11 to 10.0
4d55a70
@ivy-fhe
Downgraded from 11.0 to 10.0
679e297
@ivy-fhe
Downgraded from 11.0 to 10.0
df00f93
@ivy-fhe
Downgraded version to 10.0.6 to match latest LTS
89293ef
@ivy-fhe
fixed propertyhandler
fa17842
@ivy-fhe
streamlined file
8742de8
@ivy-fhe
deconstructed Java code into ivy process
a52ea99
@ivy-fhe
added functionality to send message to one or multiple recipients
cef7c9a 
added demo dialogs
@ivy-fhe
added test for LookupType Enum
0c667ea
@ivy-fhe
removed unneeded classes
db5046f 
added descriptions
@ivy-fhe
renamed product folder
b163a57
@ivy-fhe
removed old product folder
ff7117c
@ivy-fhe
added test for messageEncryption process
bd5dfaa
@ivy-fhe
added test for messageEncryptioadded test for messageEncryptionn
9ee25f6
@ivy-fhe
removed maven dependency and changed classpath to use lib folder
58da7bd
@ivy-fhe
added threema library to classpath
e9815a0
@ivy-fhe
added decryption to test
4aa9a87
@ivy-fhe
removed variables
8372367
@ivy-fhe
added test for process getReveiverInfo
ebc085a
@ivy-fhe
added test for process messageEncryption
8464f1c
@ivy-fhe
added test for process sendMessage
8d8c557
@ivy-fhe
Created first version of README.md
ef89b28
ivy-rew
ivy-rew reviewed Oct 20, 2023
View reviewed changes
threema-connector/pom.xml Outdated Show resolved Hide resolved
ivy-rew
ivy-rew requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ivy-rew ivy-rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice stuff; some minor things to adapt ... se my comments.
Feel free to ask back if my comments are confusing.

@ivy-fhe
Update .classpath
cf72090 
removed linebreak
@ivy-rew
Copy link
Member

ivy-rew commented Oct 20, 2023

one thing I didn't see in the initial review. the product.json must be implemented ... just delete the parts that you don't need and replace placeholders with valid group+artifactIds.
you may use vscode for editing ... as it helps you by keeping the json compliant to the schema and shows help-texts where known.

@ivy-rew ivy-rew merged commit f71d874 into axonivy-market:master Oct 20, 2023
1 check passed
ivy-fhe pushed a commit that referenced this pull request Nov 2, 2023
@ivy-rew
Merge pull request #2 from ivy-fhe/master
1c79996 
Implementation - Threema Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-rew ivy-rew ivy-rew approved these changes

Assignees

@ivy-fhe ivy-fhe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivy-fhe @ivy-rew