Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MARP-434 Authentication SSH & Multi connection #39

Merged
merged 7 commits into from
Aug 26, 2024
Merged

MARP-434 Authentication SSH & Multi connection #39

merged 7 commits into from
Aug 26, 2024

Conversation

anh-bolt
Copy link
Contributor

@anh-bolt anh-bolt commented Aug 15, 2024 •
edited
Loading

https://1ivy.atlassian.net/browse/MARP-434

  • update JSch to com.github.mwiede:jsch:0.2.19 (which support for loading new OPENSSH format key)
  • add authentication with SSH key pair
  • support multi connection with "sftpName" subset global variables

@anh-bolt anh-bolt requested a review from ptanhaxon August 15, 2024 10:04
@anh-bolt anh-bolt marked this pull request as ready for review August 15, 2024 10:05
@anh-bolt anh-bolt force-pushed the features/MARP-434-ssh-auth-multi-connect branch from cad3af1 to 30ac8ea Compare August 16, 2024 04:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

Test Results

11 tests  +6   11 ✅ +6   13s ⏱️ +3s
 3 suites +2    0 💤 ±0 
 3 files   +2    0 ❌ ±0 

Results for commit cc75755. ± Comparison against base commit d5a6083.

♻️ This comment has been updated with latest results.

@anh-bolt anh-bolt force-pushed the features/MARP-434-ssh-auth-multi-connect branch from 30ac8ea to f66cb60 Compare August 16, 2024 04:21
@anh-bolt anh-bolt requested a review from majeed-hm August 20, 2024 04:07
majeed-hm
majeed-hm reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@majeed-hm majeed-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anh-bolt ,
I finished my code review. can you please take a look? and feel free to ask me for any clarification.

...ctor-demo/src_hd/com/axonivy/connector/sftp/demo/SftpClientDemo/SftpClientDemoProcess.p.json Outdated Show resolved Hide resolved
sftp-connector-demo/src/com/axonivy/connector/sftp/demo/Constants.java Outdated Show resolved Hide resolved
...ector-demo/src_hd/com/axonivy/connector/sftp/demo/SftpClientDemo/SftpClientDemoData.ivyClass Outdated Show resolved Hide resolved
sftp-connector/src/com/axonivy/connector/sftp/service/SftpClientService.java Outdated Show resolved Hide resolved
sftp-connector-test/src_test/com/axonivy/connector/sftp/test/SftpProcessTest.java Outdated Show resolved Hide resolved
@anh-bolt anh-bolt requested a review from majeed-hm August 21, 2024 06:25
@anh-bolt anh-bolt requested review from nqhoan-axonivy and a user August 21, 2024 09:49
@anh-bolt anh-bolt requested a review from a user August 26, 2024 01:39
ghost
ghost approved these changes Aug 26, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anh-bolt anh-bolt merged commit 6010f57 into master Aug 26, 2024
4 checks passed
@anh-bolt anh-bolt deleted the features/MARP-434-ssh-auth-multi-connect branch August 26, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majeed-hm majeed-hm majeed-hm approved these changes

@ptanhaxon ptanhaxon Awaiting requested review from ptanhaxon

@nqhoan-axonivy nqhoan-axonivy Awaiting requested review from nqhoan-axonivy

Assignees

@nqhoan-axonivy nqhoan-axonivy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anh-bolt @majeed-hm @nqhoan-axonivy