IVYPORTAL-17428 Check and remove deprecated features from portal - Co…

…de + Docs Removed deprecated code
axonivy-market · Aug 28, 2024 · f6aaa9c · f6aaa9c
1 parent 0ade5ec
commit f6aaa9c
Show file tree

Hide file tree

Showing 21 changed files with 3 additions and 493 deletions.
diff --git a/...l-components/src/com/axonivy/portal/components/publicapi/PortalGlobalGrowInIFrameAPI.java b/...l-components/src/com/axonivy/portal/components/publicapi/PortalGlobalGrowInIFrameAPI.java
diff --git a/...rtal/portal-components/src/com/axonivy/portal/components/service/CaseDocumentService.java b/...rtal/portal-components/src/com/axonivy/portal/components/service/CaseDocumentService.java
@@ -62,16 +62,6 @@ public List<IDocument> getAll() {
     return new ArrayList<>(documents);
   }
 
-  /**
-   * We make it as deprecated from 8.0 Please refer to sub-function process DeleteDocument
-   * 
-   * @param document
-   */
-  @Deprecated
-  public void delete(IDocument document) {
-    documentsOf(iCase).delete(document);
-  }
-
   /**
    * @param document
    * @return streamed content

diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portal/generic/bean/UserMenuBean.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portal/generic/bean/UserMenuBean.java
@@ -239,11 +239,6 @@ public boolean isMobileDevice() {
     return RequestUtils.isMobileDevice();
   }
 
-  /**
-   * We moved this method to PortalExceptionBean#getErrorDetailToEndUser
-   * @return system configuration of ErrorDetailToEndUser
-   */
-  @Deprecated
   public boolean getErrorDetailToEndUser() {
     try {
       PortalExceptionBean portalExceptionBean = (PortalExceptionBean) ManagedBeans.find("portalExceptionBean").get();

diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bean/UserFormatBean.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bean/UserFormatBean.java
diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bo/Announcement.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bo/Announcement.java
diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/configuration/Application.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/configuration/Application.java
@@ -1,6 +1,5 @@
 package ch.ivy.addon.portalkit.configuration;
 
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonInclude;
 
 @JsonInclude(JsonInclude.Include.NON_EMPTY)
@@ -15,19 +14,6 @@ public class Application extends AbstractConfiguration {
   public Application() {
     setIsPublic(true);
   }
-  /**
-   * @deprecated not used anymore
-   */
-  @Deprecated(since = "9.2", forRemoval = true)
-  @JsonIgnore
-  private Long serverId;
-
-  /**
-   * @deprecated not used anymore
-   */
-  @Deprecated(since = "9.2", forRemoval = true)
-  @JsonIgnore
-  private boolean embedInFrame = true;
 
   public String getDisplayName() {
     return displayName;
@@ -69,46 +55,10 @@ public void setLink(String link) {
     this.link = link;
   }
 
-  /**
-   * Not used anymore
-   * @return serverId
-   */
-  @Deprecated(since = "9.2", forRemoval = true)
-  public Long getServerId() {
-    return serverId;
-  }
-
-  /**
-   * Not used anymore
-   * @param serverId
-   */
-  @Deprecated(since = "9.2", forRemoval = true)
-  public void setServerId(Long serverId) {
-    this.serverId = serverId;
-  }
-
-  /**
-   * Not used anymore
-   * @return embedInFrame
-   */
-  @Deprecated(since = "9.2", forRemoval = true)
-  public boolean isEmbedInFrame() {
-    return embedInFrame;
-  }
-
-
-  /**
-   * Not used anymore
-   * @param embedInFrame
-   */
-  @Deprecated(since = "9.2", forRemoval = true)
-  public void setEmbedInFrame(boolean embedInFrame) {
-    this.embedInFrame = embedInFrame;
-  }
-
   @Override
   public String toString() {
-    return String.format("Application {displayName=%s, menuIcon=%s, menuOrdinal=%s, name=%s, link=%s, serverId=%s, id=%s, embedInFrame=%s}", 
-      displayName, menuIcon, menuOrdinal, name, link, serverId, getId(), embedInFrame);
+    return String.format(
+        "Application {displayName=%s, menuIcon=%s, menuOrdinal=%s, name=%s, link=%s, id=%s}", displayName, menuIcon,
+        menuOrdinal, name, link, getId());
   }
 }
diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/constant/CustomFields.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/constant/CustomFields.java
@@ -2,34 +2,6 @@
 
 public class CustomFields {
 
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_VARCHAR_FIELD1 = "CustomVarCharField1";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_VARCHAR_FIELD2 = "CustomVarCharField2";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_VARCHAR_FIELD3 = "CustomVarCharField3";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_VARCHAR_FIELD4 = "CustomVarCharField4";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_VARCHAR_FIELD5 = "CustomVarCharField5";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_DECIMAL_FIELD1 = "CustomDecimalField1";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_DECIMAL_FIELD2 = "CustomDecimalField2";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_DECIMAL_FIELD3 = "CustomDecimalField3";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_DECIMAL_FIELD4 = "CustomDecimalField4";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_DECIMAL_FIELD5 = "CustomDecimalField5";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_TIMESTAMP_FIELD1 = "CustomTimestampField1";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_TIMESTAMP_FIELD2 = "CustomTimestampField2";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_TIMESTAMP_FIELD3 = "CustomTimestampField3";
-  @Deprecated(forRemoval = true, since = "9.4")
-  public static final String CUSTOM_TIMESTAMP_FIELD4 = "CustomTimestampField4";
   @Deprecated(forRemoval = true, since = "9.4")
   public static final String CUSTOM_TIMESTAMP_FIELD5 = "CustomTimestampField5";
 

diff --git a/...yPortal/portal/src/ch/ivy/addon/portalkit/dto/dashboard/ProcessViewerDashboardWidget.java b/...yPortal/portal/src/ch/ivy/addon/portalkit/dto/dashboard/ProcessViewerDashboardWidget.java
@@ -2,11 +2,8 @@
 
 import java.util.List;
 
-import org.apache.commons.lang3.StringUtils;
-
 import com.axonivy.portal.components.service.impl.ProcessService;
 import com.fasterxml.jackson.annotation.JsonIgnore;
-import com.fasterxml.jackson.annotation.JsonProperty;
 
 import ch.ivy.addon.portalkit.dto.WidgetLayout;
 import ch.ivy.addon.portalkit.dto.dashboard.process.DashboardProcess;
@@ -56,19 +53,6 @@ public void setProcessPath(String processPath) {
     this.processPath = processPath;
   }
 
-  /**
-   * @param processStart 
-   * @deprecated use {@link #setProcessPath(String)} instead
-   * The processStart is replaced by processPath
-   */
-  @Deprecated(forRemoval = true, since = "10.0.3")
-  @JsonProperty("processStart")
-  public void setProcessStart(String processStart) {
-    if (StringUtils.isBlank(processPath)) {
-      this.processPath = processStart;
-    }
-  }
-
   public DashboardProcess getProcess() {
     return process;
   }

diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/dto/widget/CustomWidgetData.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/dto/widget/CustomWidgetData.java
@@ -3,10 +3,6 @@
 import java.io.Serializable;
 import java.util.Map;
 
-import org.apache.commons.lang3.StringUtils;
-
-import com.fasterxml.jackson.annotation.JsonProperty;
-
 public class CustomWidgetData implements Serializable {
 
   private static final long serialVersionUID = 8763058243562205725L;
@@ -41,19 +37,6 @@ public void setProcessPath(String processPath) {
     this.processPath = processPath;
   }
 
-  /**
-   * @param processStart 
-   * @deprecated use {@link #setProcessPath(String)} instead
-   * The processStart is replaced by processPath
-   */
-  @Deprecated(forRemoval = true, since = "10.0.3")
-  @JsonProperty("processStart")
-  public void setProcessStart(String processStart) {
-    if (StringUtils.isBlank(processPath)) {
-      processPath = processStart;
-    }
-  }
-
   public String getType() {
     return type;
   }

diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/dto/widget/DashboardCustomWidgetData.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/dto/widget/DashboardCustomWidgetData.java
@@ -5,11 +5,8 @@
 import java.util.List;
 import java.util.Optional;
 
-import org.apache.commons.lang3.StringUtils;
-
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonInclude;
-import com.fasterxml.jackson.annotation.JsonProperty;
 
 import ch.ivy.addon.portalkit.dto.dashboard.CustomDashboardWidgetParam;
 import ch.ivy.addon.portalkit.enums.DashboardCustomWidgetType;
@@ -49,19 +46,6 @@ public void setProcessPath(String processPath) {
     this.processPath = processPath;
   }
 
-  /**
-   * @param processStart 
-   * @deprecated use {@link #setProcessPath(String)} instead
-   * The processStart is replaced by processPath
-   */
-  @Deprecated(forRemoval = true, since = "10.0.3")
-  @JsonProperty("processStart")
-  public void setProcessStart(String processStart) {
-    if (StringUtils.isBlank(processPath)) {
-      this.processPath = processStart;
-    }
-  }
-
   public String getStartRequestPath() {
     return startRequestPath;
   }