Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-1440 Finalize chat gpt assistant fix for explain feature in v11 #85

Open
wants to merge 7 commits into
base: release/10.0
Choose a base branch
from

Conversation

tvtphuc-axonivy
Copy link

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Dec 24, 2024
Copy link
Contributor

github-actions bot commented Dec 24, 2024

Test Results

8 tests  ±0   8 ✅ ±0   14s ⏱️ +2s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 07a983e. ± Comparison against base commit 86cd5ca.

♻️ This comment has been updated with latest results.

@ndkhanh-axonivy ndkhanh-axonivy changed the title Feature/marp 1440 finalize chat gpt assistant fix for explain feature in v11 MARP-1440 Finalize chat gpt assistant fix for explain feature in v11 Dec 26, 2024
Copy link
Contributor

@ndkhanh-axonivy ndkhanh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvtphuc-axonivy
Copy link
Author

tvtphuc-axonivy commented Dec 30, 2024

Hi @ivy-rew,

Currently, I am working on story https://1ivy.atlassian.net/browse/MARP-1440. When I made a release for story https://1ivy.atlassian.net/browse/MARP-747 in version 10, I encountered a compile error that required 3 arguments instead of 2 in class openai-assistant/src/com/axonivy/connector/openai/assistant/DesignerClient.java .
image

I fixed this issue and updated the pom file to use "nightly-10.0" and running "mvn clean install".

It seems like it cannot find the library in version 10: javax.ws.rsch.ivyteam.ivy.rest.client.exec'.
image

I tried removing this from the MANIFEST.MF file. Now the build has passed, I tested it and it works well in version 10.
image

Do you agree that if I remove "javax.ws.rsch.ivyteam.ivy.rest.client.exec" in the MANIFEST.MF file for only version 10 ?

@ivy-rew
Copy link
Member

ivy-rew commented Jan 2, 2025

Yes @tvtphuc-axonivy , for release/1o omitting the rest.client.exec bundle is a good solution. thanks for your efforts.

@ivy-rew
Copy link
Member

ivy-rew commented Jan 2, 2025

However, please squash your commits before merging. Otherwise we get a lot of noise in the history for a simple build fix.

@tvtphuc-axonivy
Copy link
Author

However, please squash your commits before merging. Otherwise we get a lot of noise in the history for a simple build fix.

Thanks Reguel, I will squash merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants