-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MARP-1440 Finalize chat gpt assistant fix for explain feature in v11 #85
base: release/10.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @ivy-rew, Currently, I am working on story https://1ivy.atlassian.net/browse/MARP-1440. When I made a release for story https://1ivy.atlassian.net/browse/MARP-747 in version 10, I encountered a compile error that required 3 arguments instead of 2 in class openai-assistant/src/com/axonivy/connector/openai/assistant/DesignerClient.java . I fixed this issue and updated the pom file to use "nightly-10.0" and running "mvn clean install". It seems like it cannot find the library in version 10: javax.ws.rsch.ivyteam.ivy.rest.client.exec'. I tried removing this from the MANIFEST.MF file. Now the build has passed, I tested it and it works well in version 10. Do you agree that if I remove "javax.ws.rsch.ivyteam.ivy.rest.client.exec" in the MANIFEST.MF file for only version 10 ? |
Yes @tvtphuc-axonivy , for release/1o omitting the rest.client.exec bundle is a good solution. thanks for your efforts. |
However, please squash your commits before merging. Otherwise we get a lot of noise in the history for a simple build fix. |
Thanks Reguel, I will squash merge it. |
No description provided.