Add: target platform config #80
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | ||
| <?pde version="3.8"?> | ||
| <target name="ivy"> | ||
| <locations> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <repository location="https://p2.axonivy.com/p2/11.3/"/> | ||
| <unit id="ch.ivyteam.ivy.designer.product" version="11.3.1"/> | ||
| <unit id="ch.ivyteam.ivy.designer.rule.engine.feature.feature.group" version="11.3.1.202406202109"/> | ||
| <unit id="ch.ivyteam.ivy.designer.webeditor.feature.feature.group" version="11.3.1.202406202117"/> | ||
| <unit id="ch.ivyteam.ivy.elasticsearch.feature.feature.group" version="11.3.1.202406210642"/> | ||
|
There was a problem hiding this comment. why do we need these? I'd just adapt from the slim platform defined in the excel-importer https://github.com/axonivy-market/excel-importer/blob/master/target-platform/ivy.target ... furthermore this could be a good time to also introduce/adapt the dev-docs on how to use a target-platform, just like they exist in the excel-importer. or at least a reference to these docs. There was a problem hiding this comment. I updated it to align with the target for the excel-importer. I'm preparing to leave next week, and I'm writing some documentation for my team members. I'm also referencing the dev-setup guide from the excel-importer. Thank you for reviewing |
||
| </location> | ||
| </locations> | ||
| </target> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the 11.3 platform? the code currently is written for compatibility with LTS 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why, but when I'm using LTS 10, I get this error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the APIs may are no longer the same as they are internal.
However, by using a newer platform you may get this to compile, but it will fail anyway at runtime on a Desinger10.
So either you find an API that works on 10 and 11.3 ... or you actually migrate to 11.3 and mark the artifacts as such ... with the downside that you can no longer ship anything for lts10.