MARP-1703 end2 end testing tryout with adding a new test to call to real endpoint #35

ntqdinh-axonivy · 2024-12-27T08:17:31Z

No description provided.

github-actions · 2024-12-27T08:18:45Z

Test Results

34 tests +17 34 ✅ +17 24s ⏱️ +5s
4 suites ± 0 0 💤 ± 0
4 files ± 0 0 ❌ ± 0

Results for commit 008decc. ± Comparison against base commit 1c96afc.

This pull request removes 17 and adds 34 tests. Note that renamed tests count towards both.

com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetAirPollutionByGeoCode_ThrowsBpmException(BpmClient)
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetForecastAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetForecastAirPollutionByGeoCode_ThrowsBpmException(BpmClient)
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetHistoricalAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetHistoricalAirPollutionByGeoCode_ThrowsBpmExceptionCanNotGeo(BpmClient)
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetHistoricalAirPollutionByGeoCode_ThrowsBpmExceptionStartMoreThanEnd(BpmClient)
com.axonivy.connector.openweather.test.CurrentWeatherProcessTest ‑ testGetCurrentWeatherByGeoCode_ReturnsCurrentWeather(BpmClient)
com.axonivy.connector.openweather.test.CurrentWeatherProcessTest ‑ testGetCurrentWeatherByGeoCode_ThrowsBpmException(BpmClient)
com.axonivy.connector.openweather.test.ForecastWeatherProcessTest ‑ testGetForecastByGeoCode_ThrowsBpmException(BpmClient)
…

com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)[1]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)[2]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetAirPollutionByGeoCode_ThrowsBpmException(BpmClient)[1]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetAirPollutionByGeoCode_ThrowsBpmException(BpmClient)[2]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetForecastAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)[1]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetForecastAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)[2]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetForecastAirPollutionByGeoCode_ThrowsBpmException(BpmClient)[1]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetForecastAirPollutionByGeoCode_ThrowsBpmException(BpmClient)[2]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetHistoricalAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)[1]
com.axonivy.connector.openweather.test.AirPollutionProcessTest ‑ testGetHistoricalAirPollutionByGeoCode_ReturnsAirPollution(BpmClient)[2]
…

♻️ This comment has been updated with latest results.

ntqdinh-axonivy · 2024-12-27T08:55:31Z

Hi @ivy-rew
I have just prepared some new test cases for API testing using the approach we discussed in the previous meeting.
Should we remove old test cases (with mock server) that check the response status and the instance of results?
For test cases with mock data to test the logic, we think it still need to keep it as it is, right?

ivy-rew · 2025-01-02T07:04:03Z

Hi @ivy-rew I have just prepared some new test cases for API testing using the approach we discussed in the previous meeting. Should we remove old test cases (with mock server) that check the response status and the instance of results? For test cases with mock data to test the logic, we think it still need to keep it as it is, right?

Thanks for reaching out.
I'd not remove the old mock-based tests, they still offer value, documenting how the service worked when the features were developed. Furthermore the mock-service can be used for demos ... simply adding the test-project to a workspace allows presales and others to play with the service while being offline.

open-weather-connector/config/variables.yaml

ivy-rew · 2025-01-02T07:09:15Z

...ather-connector-test/src_test/com/axonivy/connector/openweather/test/it/BaseProcessTest.java

+@IvyProcessTest(enableWebServer = true)
+public class BaseProcessTest {


junit5 should no longer be used with base-classes: normally you'd rather pack such code as in this class in a junit5-extension. And then add it to each test via @RegisterExtension

...ather-connector-test/src_test/com/axonivy/connector/openweather/test/it/BaseProcessTest.java

...nnector-test/src_test/com/axonivy/connector/openweather/test/it/AirPollutionProcessTest.java

ivy-rew

Good first steps; let's make more of the standard junit5 features to avoid duplication in our tests.... especially as we are sort of gaining experience how to apply the approach for many connectors.

ntqdinh-axonivy · 2025-01-02T07:41:02Z

Thanks for your hint on our implementation. I would have a try on your suggestion of multiple environments using TestTemplates and update the document soon. ☺️

ivy-rew · 2025-01-02T09:45:03Z

Thanks for your hint on our implementation. I would have a try on your suggestion of multiple environments using TestTemplates and update the document soon. ☺️

cool, note though that it is just a hint. maybe it's not easy to keep both impls sync ... as the service may changes its outputs.
another solution could be to parameterize the stuff only at built time.... by passing system-args to the surefire run and planning the same execution twice ... with differen params.

Unify @beforeeach to composition instead of inheritance hierarchy

- Create generic TestTemplateInvocationContext - Only change var when env change

nqhoan-axonivy

Your approach is very cool and it fits my expectaction.
But please keep the TAB format for all connector as a conversation of market product.
And I just have one small concern in the code, please help to check it.
Thanks!

...test/src/com/axonivy/connector/openweather/test/context/TestEnironmentInvocationContext.java

...eather-connector-test/src/com/axonivy/connector/openweather/test/utils/OpenWeatherUtils.java

nqhoan-axonivy

LGTM

ntqdinh-axonivy added 3 commits December 27, 2024 14:10

update test case with real call

111064e

provide mvn arg for dev build

addcc19

change package name of it test

2f41401

github-actions bot added the enhancement New feature or request label Dec 27, 2024

ntqdinh-axonivy added 2 commits December 27, 2024 15:20

remove result log from test case

ea1a226

remove had text from test case

3ac46cf

ivy-rew reviewed Jan 2, 2025

View reviewed changes

open-weather-connector/config/variables.yaml Outdated Show resolved Hide resolved

ivy-rew reviewed Jan 2, 2025

View reviewed changes

...ather-connector-test/src_test/com/axonivy/connector/openweather/test/it/BaseProcessTest.java Outdated Show resolved Hide resolved

ivy-rew reviewed Jan 2, 2025

View reviewed changes

...nnector-test/src_test/com/axonivy/connector/openweather/test/it/AirPollutionProcessTest.java Outdated Show resolved Hide resolved

ivy-rew reviewed Jan 2, 2025

View reviewed changes

ntqdinh-axonivy and others added 7 commits January 3, 2025 01:43

Handle feedback

9edec0e

Unify @beforeeach to composition instead of inheritance hierarchy

Refactor test case with multiple env

278f77a

Fix failed in compiling

9802bcc

fix: app.yaml config corrupt in test, due to feature setup

ed0d10b

Update parameter resolver

015c8d0

refactor test code

6298926

- Create generic TestTemplateInvocationContext - Only change var when env change

return default variable value + format code

a0b14f9

nqhoan-axonivy requested changes Jan 8, 2025

View reviewed changes

...test/src/com/axonivy/connector/openweather/test/context/TestEnironmentInvocationContext.java Outdated Show resolved Hide resolved

...eather-connector-test/src/com/axonivy/connector/openweather/test/utils/OpenWeatherUtils.java Outdated Show resolved Hide resolved

ntqdinh-axonivy added 2 commits January 8, 2025 14:11

format code + handle feedback

57e8650

format code

008decc

ntqdinh-axonivy requested a review from nqhoan-axonivy January 8, 2025 07:18

nqhoan-axonivy approved these changes Jan 8, 2025

View reviewed changes

ntqdinh-axonivy merged commit 3e7c1c1 into master Jan 8, 2025
8 checks passed

ntqdinh-axonivy deleted the feature/MARP-1703-End2End-Testing-Tryout-with-adding-a-new-Test-to-call-to-real-endpoint branch January 8, 2025 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MARP-1703 end2 end testing tryout with adding a new test to call to real endpoint #35

MARP-1703 end2 end testing tryout with adding a new test to call to real endpoint #35

ntqdinh-axonivy commented Dec 27, 2024

github-actions bot commented Dec 27, 2024 •

edited

Loading

ntqdinh-axonivy commented Dec 27, 2024 •

edited

Loading

ivy-rew commented Jan 2, 2025

ivy-rew Jan 2, 2025 •

edited

Loading

ivy-rew left a comment

ntqdinh-axonivy commented Jan 2, 2025

ivy-rew commented Jan 2, 2025

nqhoan-axonivy left a comment

nqhoan-axonivy left a comment

		@IvyProcessTest(enableWebServer = true)
		public class BaseProcessTest {

MARP-1703 end2 end testing tryout with adding a new test to call to real endpoint #35

MARP-1703 end2 end testing tryout with adding a new test to call to real endpoint #35

Conversation

ntqdinh-axonivy commented Dec 27, 2024

github-actions bot commented Dec 27, 2024 • edited Loading

Test Results

ntqdinh-axonivy commented Dec 27, 2024 • edited Loading

ivy-rew commented Jan 2, 2025

ivy-rew Jan 2, 2025 • edited Loading

Choose a reason for hiding this comment

ivy-rew left a comment

Choose a reason for hiding this comment

ntqdinh-axonivy commented Jan 2, 2025

ivy-rew commented Jan 2, 2025

nqhoan-axonivy left a comment

Choose a reason for hiding this comment

nqhoan-axonivy left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2024 •

edited

Loading

ntqdinh-axonivy commented Dec 27, 2024 •

edited

Loading

ivy-rew Jan 2, 2025 •

edited

Loading