Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-259 mattermost connector - update document #2

Merged

Conversation

phhung-axonivy
Copy link
Collaborator

No description provided.

@phhung-axonivy phhung-axonivy requested a review from ivy-sgi June 5, 2024 04:21
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Test Results

6 tests  ±0   6 ✅ ±0   14s ⏱️ ±0s
3 suites ±0   0 💤 ±0 
3 files   ±0   0 ❌ ±0 

Results for commit d2bb47a. ± Comparison against base commit 0bbf7ae.

♻️ This comment has been updated with latest results.

@phhung-axonivy
Copy link
Collaborator Author

Hi @ivy-sgi
I create this pull request for the document.
Could you help me review it?

@ivy-sgi
Copy link
Member

ivy-sgi commented Jun 5, 2024

Hi @phhung-axonivy ! I like the connector very much - let's ask @andreasbalsiger what he thinks about the documentation.

@ivy-sgi ivy-sgi requested a review from andreasbalsiger June 5, 2024 06:37
Copy link

@andreasbalsiger andreasbalsiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments.

README.md Outdated Show resolved Hide resolved
mattermost-connector-product/README.md Outdated Show resolved Hide resolved
mattermost-connector-product/README.md Outdated Show resolved Hide resolved
@phhung-axonivy
Copy link
Collaborator Author

Hi @andreasbalsiger
I have updated the document by your comments.
If it's good now, please approve the pull request. I can process to next step.

@phhung-axonivy phhung-axonivy merged commit 5990edd into master Jun 6, 2024
3 checks passed
@phhung-axonivy phhung-axonivy deleted the feature/MARP-259-mattermost-connector-update-document branch June 6, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants