Skip to content

Commit

Permalink
Handle feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
phhung-axonivy committed Dec 19, 2024
1 parent 836c5ce commit bd3957f
Show file tree
Hide file tree
Showing 9 changed files with 43 additions and 25 deletions.
2 changes: 2 additions & 0 deletions .settings/org.eclipse.core.resources.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
1 change: 0 additions & 1 deletion master-detail-demo/.settings/ch.ivyteam.ivy.designer.prefs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ch.ivyteam.ivy.designer.preferences.DataClassPreferencePage\:DEFAULT_NAMESPACE=com.axonivy.demo
ch.ivyteam.ivy.project.preferences\:PORTAL_VERSION=10
ch.ivyteam.ivy.project.preferences\:PRIMEFACES_VERSION=13
ch.ivyteam.ivy.project.preferences\:PROJECT_VERSION=120001
eclipse.preferences.version=1
2 changes: 2 additions & 0 deletions master-detail-demo/.settings/org.eclipse.core.resources.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
1 change: 1 addition & 0 deletions master-detail-demo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<packaging>iar</packaging>
<properties>
<project.build.plugin.version>12.0.0</project.build.plugin.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
<pluginRepositories>
<pluginRepository>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@
<div class="ui-g">
<div class="ui-g-12">
<p:commandButton id="saveProduct" value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/save')}"
styleClass="buttonMargin" icon="fa fa-check" actionListener="#{logic.save}" action="ProductList" style="float:right" />
styleClass="buttonMargin" icon="fa fa-check" actionListener="#{logic.save}" style="float:right" />
<p:commandButton value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/cancel')}"
icon="fa fa-times" style="float:right" action="ProductList" />
icon="fa fa-times" style="float:right" />
</div>
</div>
</h:form>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,24 +210,34 @@
</f:facet>
<p:outputLabel value="#{product.onSale == true ? ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/yes') : (product.onSale == false ? ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/no') : '')}" />
</p:column>

<p:column id="actionsColumn" resizable="false"
headerText="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/actions')}"
styleClass="zoneColumnCaseTable" selectRow="false">

<p:tooltip for="editThroughProcess" value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/tooltipEditThroughProcess')}" position="right"/>
<p:commandLink id="editThroughProcess" global="false" action="#{logic.onEditThroughProcessClicked(product.id)}" >
<p:tooltip for="editThroughProcess"
value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/tooltipEditThroughProcess')}"
position="right" />
<p:commandLink id="editThroughProcess" global="false"
action="#{logic.onEditThroughProcessClicked(product.id)}">
<h:outputText styleClass="fa fa-pencil" />
</p:commandLink>

<p:tooltip for="editByLink" value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/tooltipEditByLink')}" position="right"/>
<p:commandLink id="editByLink" global="false" action="#{logic.onEditByLinkClicked(product.id)}" >
<p:tooltip for="editByLink"
value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/tooltipEditByLink')}"
position="right" />
<p:commandLink id="editByLink" global="false"
action="#{logic.onEditByLinkClicked(product.id)}">
<h:outputText styleClass="fa fa-link" />
</p:commandLink>

<p:tooltip for="editWithViews" value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/tooltipEditWithViews')}" position="right"/>
<p:commandLink id="editWithViews" global="false" action="ProductDetail" actionListener="#{logic.onEditByViewsClicked(product)}">
<h:outputText styleClass="fa fa-eye" />
<p:tooltip for="editWithViews"
value="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/tooltipEditWithViews')}"
position="right" />
<p:commandLink id="editWithViews" global="false"
action="ProductDetail"
actionListener="#{logic.onEditByViewsClicked(product)}">
<h:outputText styleClass="fa fa-eye" />
</p:commandLink>

</p:column>
Expand All @@ -242,7 +252,7 @@
<div class="ui-g-6">
<p:commandButton value="Close Product List" icon="fa fa-times" style="float:right" actionListener="#{logic.close}"/>
</div>
</div>
</div>
</h:form>


Expand Down Expand Up @@ -343,19 +353,21 @@
</div>
</h:form>
</p:dialog>



<p:confirmDialog id="deleteProductsDialog"
message="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/deletionMessage')}"
header="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/deletionHeader')}"
widgetVar="deleteProductsDialog" appendTo="@(body)" severity="alert" responsive="true">
<p:commandButton value="#{ivy.cms.co('/Labels/no')}" styleClass="buttonMargin"
onclick="PF('deleteProductsDialog').hide();" type="button" />
<p:commandButton id="confirmDODelete" value="#{ivy.cms.co('/Labels/yes')}"
actionListener="#{logic.deleteSelected}"
oncomplete="PF('deleteProductsDialog').hide();PF('productTable').filter();"
update="#{p:resolveFirstComponentWithId('productTable', view).clientId}" />
</p:confirmDialog>
message="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/deletionMessage')}"
header="#{ivy.cms.co('/Dialogs/com/axonivy/demo/masterdetail/ui/ProductList/deletionHeader')}"
widgetVar="deleteProductsDialog" appendTo="@(body)" severity="alert"
responsive="true">
<p:commandButton value="#{ivy.cms.co('/Labels/no')}"
styleClass="buttonMargin"
onclick="PF('deleteProductsDialog').hide();" type="button" />
<p:commandButton id="confirmDODelete"
value="#{ivy.cms.co('/Labels/yes')}"
actionListener="#{logic.deleteSelected}"
oncomplete="PF('deleteProductsDialog').hide();PF('productTable').filter();"
update="#{p:resolveFirstComponentWithId('productTable', view).clientId}" />
</p:confirmDialog>
</ui:define>
</ui:composition>
</h:body>
Expand Down
1 change: 0 additions & 1 deletion master-detail-test/.settings/ch.ivyteam.ivy.designer.prefs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ch.ivyteam.ivy.designer.preferences.DataClassPreferencePage\:DEFAULT_NAMESPACE=com.axonivy.demo.masterdetail.test
ch.ivyteam.ivy.project.preferences\:PORTAL_VERSION=10
ch.ivyteam.ivy.project.preferences\:PRIMEFACES_VERSION=13
ch.ivyteam.ivy.project.preferences\:PROJECT_VERSION=120001
eclipse.preferences.version=1
2 changes: 2 additions & 0 deletions master-detail-test/.settings/org.eclipse.core.resources.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
1 change: 1 addition & 0 deletions master-detail-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<properties>
<project.build.plugin.version>12.0.0</project.build.plugin.version>
<tester.version>12.0.1</tester.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
<pluginRepositories>
<pluginRepository>
Expand Down

0 comments on commit bd3957f

Please sign in to comment.