Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5

Merged
12 commits merged into from
Nov 21, 2023
Merged

Develop #5

12 commits merged into from
Nov 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Test Results

1 tests  +1   1 ✔️ +1   32s ⏱️ +32s
1 suites +1   0 💤 ±0 
1 files   +1   0 ±0 

Results for commit fa2e0f9. ± Comparison against base commit c165663.

♻️ This comment has been updated with latest results.

@ghost
Copy link
Author

ghost commented Sep 27, 2023

Hi @weissreto I am trying to run project from source then I ran "dockerDemo/start.ivp" and encountered this error
log.txt
My computer not install docker because the ICT report that we must get approval from PO before install docker

@weissreto
Copy link
Member

Hi @linhpd-axonivy
The error is because in the variables.yaml the connection to dockerd is by default defined as Unix Pipe. This will work only on Linux systems. If you want to test it on Windows you need to change to a Named Windows Pipe or TCP/IP.
And of course you need to install Docker or configure a connection to a remote host that is running Docker.

@ghost
Copy link
Author

ghost commented Sep 29, 2023

Hi @weissreto
I installed docker in my computer and set url in variable.yml to "localhost", then I run "dockerDemo/start.ivp" and encounterd this error
image
image
log.txt

@weissreto
Copy link
Member

Hi @linhpd-axonivy
Sorry, I was in holidays the last two weeks.
Have a look at the comment above URL value in the yaml. There you see how you have to set the URL value for Windows.
Regards
Reto

@ghost
Copy link
Author

ghost commented Oct 20, 2023

Hi @weissreto
I just tested the URL value 'localhost' according to your note in 'variables.yaml'. However, I don't know how to get my local Docker URL. I think you should create a guideline in the README that instructs users on how to get the link to configure it. This would be helpful for me and other users to test and use the connector.

@weissreto
Copy link
Member

Hi @linhpd-axonivy

In the variables.yaml file there is a large comment/doc section above the URL. Have look there to learn how to configure the URL for your OS. I don' t think it is necessary to but doc these into README as it fits better in the variables.yaml where you need to configure URL.

@weissreto
Copy link
Member

If the comment/doc is not clear how should I improve it so that you better understand what you need to configure?

@ghost
Copy link
Author

ghost commented Oct 20, 2023

Hi @weissreto I don't know if the comments are unclear or if this is my personal issue. As a developer, I use Docker via Docker Desktop, Rancher Desktop, or Podman Desktop to manage my containers because they are easy to install and have a UI. So I don't know how to get the 'URL to communicate with the docker daemon' on my computer. Could you give me a keyword or a guideline to help me find it?

@weissreto
Copy link
Member

Hi

If you use Docker Desktop with WSL 2 you can use this value as documented in the variables.yaml file:
npipe:////./pipe/dockerDesktopLinuxEngine

@ghost
Copy link
Author

ghost commented Oct 20, 2023

I change URL in variable.yml to npipe:////./pipe/dockerDesktopLinuxEngine and start dockerDemo/start.ivp and got this error
log_20_10_2023.txt

@weissreto
Copy link
Member

Let us do a MSTeams Remote Session on Monday. So I can analyze the problem and help you setup your environment correctly.
What is your mail address? Ok, for you at 10:30 CET?
Regards
Reto

@ghost
Copy link
Author

ghost commented Oct 23, 2023

Hi @weissreto , It's okay for me. This is my email address: [email protected]

@ghost
Copy link
Author

ghost commented Oct 23, 2023

Hi @weissreto, please help me add these lines to variables.yml because I don't have push permission
# Window Pipe use Podman (https://podman.io/)
# npipe:////./pipe/docker_engine

@ghost
Copy link
Author

ghost commented Oct 23, 2023

Hi @weissreto, I got error when stop container both case demo and test
log_23_10_2023.txt

@weissreto
Copy link
Member

The error is strange. Seems like it tries to connect using URL tcp://localhost:2375 instead of the pipe we have configured. Can you update your git repo to the latest version I just pushed and then restart the Designer and try again with the URL for podman?

@ghost
Copy link
Author

ghost commented Oct 24, 2023

HI @weissreto, I pulled latest version. The demo works well but when I run the tests, it causes the same error as mentioned above.

@@ -0,0 +1,16 @@
# Docker Connector
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andreasbalsiger,
Could you please help review if the readme file fits the market landscape?
Regards
Linh

@weissreto
Copy link
Member

HI @weissreto, I pulled latest version. The demo works well but when I run the tests, it causes the same error as mentioned above.

Hi, I just tried it out on my machine. It works. Also in the Git Hub Actions it works. Let's do another MS teams meeting tomorrow morning CET to find out why it is not running on your machine. 09:30 CET ok for you?

@ghost
Copy link
Author

ghost commented Oct 25, 2023

Hi, it's ok for me

@ghost
Copy link
Author

ghost commented Oct 25, 2023

Hi @weissreto , this is the latest logs file
log25.txt

@weissreto
Copy link
Member

Hi @linhpd-axonivy

I've setup a new dev environment with PodMan and was able to reproduce the error you had.
I've made the code now more robust. It works now with PodMan on my dev environment.
Can you test if it runs on your machine now too?

Thanks

@ghost ghost merged commit 80c49b2 into master Nov 21, 2023
5 checks passed
@ghost ghost deleted the develop branch November 21, 2023 02:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant