Skip to content

Commit

Permalink
Remove commented code and improve documentation for podman
Browse files Browse the repository at this point in the history
  • Loading branch information
weissreto committed Oct 23, 2023
1 parent 12f3976 commit 202d0db
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
10 changes: 8 additions & 2 deletions docker-connector/config/variables.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,18 @@
Variables:
Docker:
# URL to communicate with the docker daemon
# Windows Pipe (localhost only):
# Windows Docker Desktop [https://www.docker.com/products/docker-desktop/] (localhost only):
# npipe:////./pipe/dockerDesktopLinuxEngine
#
# Windows Podman [https://podman.io] (localhost only):
# npipe:////./pipe/docker_engine
#
# Linux (localhost only):
# unix:///var/run/docker.sock
#
# TCP (Outside container):
# tcp://localhost:2375
#
# TCP (Inside a container):
# tcp://host.docker.internal:2375
# tcp://host.docker.internal:2375
URL: "unix:///var/run/docker.sock"
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,10 @@ private static DockerClient createDockerClient() {
var dockerUrl = Ivy.var().get("Docker.URL");
var config = DefaultDockerClientConfig.createDefaultConfigBuilder()
.withDockerHost(dockerUrl)
// .withDockerTlsVerify(true)
// .withDockerCertPath("C:\\Users\\rwei.ZUGPCRWEI2\\AppData\\Local\\Docker\\pki")
.build();

var httpClient = new ApacheDockerHttpClient.Builder()
.dockerHost(config.getDockerHost())
// .sslConfig(config.getSSLConfig())
.maxConnections(100)
.connectionTimeout(Duration.ofSeconds(30))
.responseTimeout(Duration.ofSeconds(45))
Expand Down Expand Up @@ -113,5 +110,4 @@ public void copyToContainer(Path hostPath, String containerId, String containerP
.withRemotePath(containerPath)
.exec();
}

}

0 comments on commit 202d0db

Please sign in to comment.