Standard logging #232
Merged
Standard logging #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's bad practice to enforce IO in the code, rather than by configuration
ivy-rew
commented
Oct 31, 2023
Comment on lines
-29
to
-30
| IOFileFilter filter = new SuffixFileFilter(".log"); | ||
| Collection<File> logs = DiCore.getGlobalInjector().getInstance(IFileAccess.class).getLogFiles(filter); |
There was a problem hiding this comment.
this is the reason why I'd like to drop that adventurous logging feature.
It uses our internal IFileAccess ... which would force use to maintain a master+release/10 branch.
I see no benefit in this strict IO enforcing code ... rather logging to an extra file should be solved with an optional appender.
ivy-rew
commented
Oct 31, 2023
| } | ||
| } | ||
| } | ||
|
|
||
| public DocFactoryLogDirectoryRetriever getLogDirectoryRetriever() { |
There was a problem hiding this comment.
In theory we're dropping accessible API. I assume that it is not worth to keep it with an empty implementation.
ivy-rew
force-pushed
the
standardLogging
branch
4 times, most recently
from
09f3b2e to
ba860ed
Compare
ivy-rew
force-pushed
the
standardLogging
branch
from
ba860ed to
8a9eddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.