Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 12.0 🐫 #44

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Migrate to 12.0 🐫 #44

merged 6 commits into from
Dec 2, 2024

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Nov 29, 2024

A friendly conversion provided by market-up2date-keeper 🤖 🤝

Copy link
Contributor

Test Results

2 tests   2 ✅  14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2629ddb.

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Test Results

2 tests   2 ✅  15s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2629ddb.

♻️ This comment has been updated with latest results.

@nqhoan-axonivy
Copy link
Contributor

nqhoan-axonivy commented Nov 29, 2024

[WAIT] Contacted Thomas already but still cannot get an accesskey for DeepL API testing
=> Next action: Discuss with Alex Scharping to create a new account => need a credit card

@ivy-rew
Copy link
Member Author

ivy-rew commented Dec 2, 2024

[WAIT] Contacted Thomas already but still cannot get an accesskey for DeepL API testing => Next action: Discuss with Alex Scharping to create a new account => need a credit card

IMHO we could also migrate the project to 12 without actually testing the compliance with the real life API of deepL.
We have a mock service in test project which we can use to simulate the real execution ... with it we can verify the functionality of the connector and demo.

By example: go to your Designer install directory, navigate into the configuration dir, create an app.yaml file and put in the following contents.

# yaml-language-server: $schema=https://json-schema.axonivy.com/app/12.0.0/app.json
RestClients:
  deepl:
    Url: '{ivy.app.baseurl}/api/mock'
    Properties:
      AUTH.deepLKey: notMyKey
    Features:
    - ch.ivyteam.ivy.rest.client.mapper.JsonFeature
    - org.glassfish.jersey.media.multipart.MultiPartFeature
    - ch.ivyteam.ivy.rest.client.security.CsrfHeaderFeature

With this the Designer will fire against the local mock backend, rather than the real deepl endpoints. Through this you can test the whole project for its compatibility to version 12.

work-with-mock
app-yaml-deepl

@ivy-rew
Copy link
Member Author

ivy-rew commented Dec 2, 2024

I'll document this app.yaml development approach in readme @nqhoan-axonivy

@nqhoan-axonivy
Copy link
Contributor

Hurray... got it. so let me go to next step

Copy link
Contributor

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nqhoan-axonivy nqhoan-axonivy merged commit 0a296e4 into master Dec 2, 2024
7 checks passed
@nqhoan-axonivy nqhoan-axonivy deleted the raise-to-12.0.0-SNAPSHOT branch December 2, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants