Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-620 Add publish-release workflow #41

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

ndkhanh-axonivy
Copy link
Contributor

This PR adds the Release Drafter workflow to the repository.

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Test Results

2 tests  ±0   2 ✅ ±0   14s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c0c8a2b. ± Comparison against base commit 76f2737.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, please don't merge this PR:
the master file https://github.com/axonivy-market/github-workflows/blob/v4/.github/workflows/release-drafter.yml has no event workflow-call.
So @ndkhanh-axonivy please create a PR to adapt it, then maybe you must change this script to v5 or higher

@ivy-rew
Copy link
Member

ivy-rew commented Aug 21, 2024

Hold on, please don't merge this PR: the master file https://github.com/axonivy-market/github-workflows/blob/v4/.github/workflows/release-drafter.yml has no event workflow-call. So @ndkhanh-axonivy please create a PR to adapt it, then maybe you must change this script to v5 or higher

I think we could also re-use the tag v4 (as we do not introduce any changes for the existing pipelines)
Simply delete the v4 remote tag in github-workflows and re-create it from a commit that contains the release-drafter should be sufficient.

@github-actions github-actions bot added the enhancement New feature or request label Aug 22, 2024
Copy link
Contributor

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndkhanh-axonivy ndkhanh-axonivy changed the title MARP-620 Add release-drafter workflow MARP-620 Add publish-release workflow Aug 26, 2024
@ndkhanh-axonivy ndkhanh-axonivy merged commit c326e0b into master Aug 26, 2024
5 checks passed
@ndkhanh-axonivy ndkhanh-axonivy deleted the feature/MARP-620-Add-release-drafter-workflow branch August 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants