TE-644: Fix review code to release first version

[trungmaihova]

No description provided.

[github-actions]

Test Results

10 tests  ±0   10 ✅ ±0   12s ⏱️ +3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2bb633c. ± Comparison against base commit 8985c98.

♻️ This comment has been updated with latest results.

[ntqdinh-axonivy]

LGTM

[ivy-rew]

@ntqdinh-axonivy it seems like this connector is not built upon the ivy REST stack; I think that would be very important. This is a responsibility of team Octopus throughout the review to verify the technical approach for integrating well into the existing Axonivy environment. So I miss a discussion on this 🤔

Let me point out some features we miss by using the azure-sdk:

• no automatic logs on remote calls
• no tracing support to identify failing or slow requests
• limited configuration support to control the URIs or users
• no support to test the connectability within the cockpit

We may can continue by using the azure-sdk, but the HTTP client it uses should be Ivy.rest/Jersey ... otherwise we loose all the power of the platform supporting this connector.

[ntqdinh-axonivy]

@ntqdinh-axonivy it seems like this connector is not built upon the ivy REST stack; I think that would be very important. This is a responsibility of team Octopus throughout the review to verify the technical approach for integrating well into the existing Axonivy environment. So I miss a discussion on this 🤔

Let me point out some features we miss by using the azure-sdk:

• no automatic logs on remote calls
• no tracing support to identify failing or slow requests
• limited configuration support to control the URIs or users
• no support to test the connectability within the cockpit

We may can continue by using the azure-sdk, but the HTTP client it uses should be Ivy.rest/Jersey ... otherwise we loose all the power of the platform supporting this connector.

@ivy-rew Thanks for your feedback.
We will release a new version soon to make it much more match with AxonIvy platform.