Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev113 #23

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Dev113 #23

merged 4 commits into from
Jul 24, 2024

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Jul 24, 2024

No description provided.

Copy link

github-actions bot commented Jul 24, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 68297e9. ± Comparison against base commit ba4a211.

♻️ This comment has been updated with latest results.

@ivy-rew ivy-rew requested a review from nqhoan-axonivy July 24, 2024 13:26
@ivy-rew ivy-rew marked this pull request as ready for review July 24, 2024 13:26
@ivy-rew
Copy link
Member Author

ivy-rew commented Jul 24, 2024

I've a customer asking for the 11.3 express ... so I'll merge it in a hurry.
Feel free to provide feedback later on anyway.

@ivy-rew ivy-rew merged commit e5647c6 into master Jul 24, 2024
3 of 4 checks passed
@ivy-rew ivy-rew deleted the dev113 branch July 24, 2024 13:26
@nqhoan-axonivy
Copy link
Contributor

Thank @ivy-rew so much for your support!
The DEV build is green so it's very cool to me.
Just a small concern about the param -Dportal.version when compiling and the dependency in the pom of the project is a little bit different 11.4.0-m261 and 11.3.1.

@ivy-rew
Copy link
Member Author

ivy-rew commented Jul 25, 2024

Thanks for your feedback @nqhoan-axonivy , I have reverted this change in a follow up PR:
#25

The intention was to test in the dev-pipeline that latest engine+portal , but unfortunately we cannot easily replace the portal-dependency by properties without braking the Designer-support. So this parameter is obsolete anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants