Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AxoUpdater::install_prefix_root public #221

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Nov 28, 2024

We need access to this (or similar) to avoid confusion, e.g., astral-sh/uv#6774 (comment), when the receipt is for a different uv executable. See astral-sh/uv#9487, which uses this change to power a message like:

❯ cargo run --all-features -q -- self update
warning: Self-update is only available for uv binaries installed via the standalone installation scripts.

The current executable is at `/Users/zb/workspace/uv/target/debug/uv` but the standalone installer was used to install uv to `/Users/zb/.cargo`. Are multiple copies of uv installed?

Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable - I'm happy for us to make this public.

@mistydemeo mistydemeo merged commit cfdad67 into axodotdev:main Dec 4, 2024
12 checks passed
@zanieb
Copy link
Contributor Author

zanieb commented Dec 4, 2024

Thanks @mistydemeo

zanieb added a commit to astral-sh/uv that referenced this pull request Dec 4, 2024
…#9487)

Attempts to improve confusing messaging in cases like
#6774 (comment),
when the receipt is for a different uv executable.

```
❯ cargo run --all-features -q -- self update
warning: Self-update is only available for uv binaries installed via the standalone installation scripts.

The current executable is at `/Users/zb/workspace/uv/target/debug/uv` but the standalone installer was used to install uv to `/Users/zb/.cargo`. Are multiple copies of uv installed?
```

Requires axodotdev/axoupdater#221
Closes #6774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants