form: check for parent to determine if an element is hidden #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you please rebase this patch on dev branch? We may include in this next 5.0.x release. |
isHidden only checks for current element being hidden, this leads to false negative when eg. element is in an hidden panel (for exemple productName in SaleOrderLine.xml which is present twice, only one of the two being displayed).
|
@axeloradmin Done :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isHidden only checks for current element being hidden, this leads to
false negative when eg. element is in an hidden panel (for exemple
productName in SaleOrderLine.xml which is present twice, only one of the
two being displayed).
This fixes a double error message in SaleOrderLine popup when product label is empty