refactor: remove attached files feature from core package

changelogs/unreleased/88363.json

@@ -0,0 +1,5 @@
+{
+  "title": "Attached files: remove attached files feature from core package",
+  "type": "feat",
+  "packages": "core"
+}

docs/doc/en/Outil/Gestion_des_headers.md

@@ -42,26 +42,30 @@ export interface HeaderActions {
 export interface HeaderOptions {
   model?: string;
   modelId?: number;
+  options?: any;
+  disablePrint?: boolean;
   disableMailMessages?: boolean;
   disableJsonFields?: boolean;
-  attachedFileScreenTitle?: string;
   barcodeFieldname?: string;
   headerTitle?: string;
   actions?: ActionType[];
 }
 ```
 
-By default, the core package provides two actions for the header: follow-up messages on each object and attached files. These can be configured via the following props:
+By default, the core package provides a few actions for the header: follow-up messages on each object, barcode display, custom fields or even report printing. These can be configured via the following props:
 
 - _model_: full name of the ERP model.
 - _modelId_: object identifier.
+- _options_: object containing options for the generic actions.
+- _disablePrint_: condition for displaying or not report printing on the object.
 - _disableMailMessages_: condition for displaying or not displaying follow-up messages on the object.
 - _disableJsonFields_: condition for displaying studio fields.
-- _attachedFileScreenTitle_: screen name for attached files.
 - _barcodeFieldname_: name of attribute containing barcode file on ERP (default `barCode`).
 - _headerTitle_: screen name for dynamic titles.
 
-Attached files are displayed only if the current object has them, with an indicator of their number. Follow-up messages are only displayed when `model` and `modelId` are set and not disabled by the `disableMailMessages` attribute.
+:::caution
+Since version 8.3, the attached files feature is managed as a generic action from the DMS package. It will be added to every screen with a registered model and modelId.
+:::
 
 Additional actions can then be added using the `actions` attribute. Each action then has the following structure:
 

docs/doc/fr/Outil/Gestion_des_headers.md

@@ -42,26 +42,30 @@ export interface HeaderActions {
 export interface HeaderOptions {
   model?: string;
   modelId?: number;
+  options?: any;
+  disablePrint?: boolean;
   disableMailMessages?: boolean;
   disableJsonFields?: boolean;
-  attachedFileScreenTitle?: string;
   barcodeFieldname?: string;
   headerTitle?: string;
   actions?: ActionType[];
 }
 ```
 
-Le package core fournit par défaut deux actions pour le header qui sont les messages de suivi sur chaque objet ainsi que les fichiers joints. Elles sont paramétrables via les props suivantes :
+Le package core fournit par défaut plusieurs actions pour le header: les messages de suivi sur chaque objet, l'affichage du code-barre, les champs studio or encore l'impression de rapport. Elles sont paramétrables via les props suivantes :
 
 - _model_ : nom complet du modèle sur l’ERP.
 - _modelId_ : identifiant de l’objet.
+- _options_: objet contenant des options pour les actions génériques.
+- _disablePrint_: ccondition pour l'affichage ou non de l'impression de rapport.
 - _disableMailMessages_ : condition pour l'affichage ou non des messages de suivi sur l'objet.
 - _disableJsonFields_ : condition pour l’affichage ou non des champs studio.
-- _attachedFileScreenTitle_ : nom de l'écran pour les fichiers joints.
 - _barcodeFieldname_ : nom de l’attribut contenant le fichier code-barre sur l’ERP (par défaut `barCode`).
 - _headerTitle_ : nom de l'écran pour permettre les titres dynamiques.
 
-Les fichiers joints s’affichent uniquement si l’objet actuel en possède avec un indicateur sur leur nombre. Les messages de suivi eux n’affichent lorsque `model` et `modelId` sont renseignés et qu’il ne sont pas désactivés par l’attribut `disableMailMessages`.
+:::caution
+Depuis la version 8.3, la fonctionnalité des fichiers joints est gérée comme une action générique du module DMS. Elle sera ajoutée à tous les écrans avec un model et un modelId enregistrés.
+:::
 
 Il est ensuite possible d’ajouter des actions supplémentaires avec l’attribut `actions`. Chaque action possède alors la structure suivante :
 

packages/core/README.md

@@ -19,7 +19,7 @@ It contains:
 - Auth module with login and user screens
 - Translations management system
 - Various helper tools : clipboard, file viewer, external app management
-- Management of MailMessages and attaches files on objects
+- Management of MailMessages
 - AOS linked components or using external libraries : Camera, Scanner, PlanningView, Stopwatch, ...
 - Menu management
 - Storage management
@@ -306,13 +306,13 @@ const Colors = useThemeColor();
 )}
 ```
 
-### Add MailMessages and attached files
+### Add MailMessages
 
-- Management of MailMessages and attaches files on objects
+- Management of MailMessages on objects
 
-This package provides a component to add MailMessages and file attachments functionality to the header. This component also allows to display its children if there are any as a dropdown menu.
+This package provides a component to add MailMessages functionality to the header. This component also allows to display its children if there are any as a dropdown menu.
 
-For the first two functionalities of this component, it is necessary to provide in props the name of the object model ("com.axelor.apps.stock.db.StockCorrection" for the stock corrections for example), the id of the current object, and the navigation attribute to go on the dedicated screens:
+For the first functionality of this component, it is necessary to provide in props the name of the object model ("com.axelor.apps.stock.db.StockCorrection" for the stock corrections for example), the id of the current object, and the navigation attribute to go on the dedicated screens:
 
 ```typescript
 import {HeaderOptionsMenu} from '@axelor/aos-mobile-core';
@@ -326,8 +326,7 @@ React.useLayoutEffect(() => {
         <HeaderOptionsMenu
           model={...}
           modelId={...}
-          navigation={navigation}
-          disableMailMessages={...}>
+          navigation={navigation}>
           <DropdownMenuItem
             icon="..."
             placeholder={...}

packages/core/src/api/metafile-api.ts

@@ -46,13 +46,9 @@ const createCriteria = (listFiles): Criteria[] => {
   return [];
 };
 
-export async function fetchFileDetails({listFiles, isMetaFile}) {
-  const model = isMetaFile
-    ? 'com.axelor.meta.db.MetaFile'
-    : 'com.axelor.dms.db.DMSFile';
-
+export async function fetchFileDetails({listFiles}) {
   return createStandardSearch({
-    model: model,
+    model: 'com.axelor.meta.db.MetaFile',
     criteria: createCriteria(listFiles),
     fieldKey: 'core_metaFile',
     numberElementsByPage: null,

packages/core/src/components/organisms/HeaderOptionsMenu/HeaderOptionsMenu.js

@@ -34,12 +34,10 @@ const HeaderOptionsMenu = ({
   disableMailMessages,
   disableJsonFields,
   disablePrint,
-  attachedFileScreenTitle,
   barcodeFieldname,
 }) => {
   const {
     mailMessagesAction,
-    attachedFilesAction,
     barcodeAction,
     printAction,
     jsonFieldsAction,
@@ -52,7 +50,6 @@ const HeaderOptionsMenu = ({
     disablePrint,
     barcodeFieldname,
     disableJsonFields,
-    attachedFileScreenTitle,
   });
 
   const collapseMenuItems = useMemo(
@@ -88,7 +85,6 @@ const HeaderOptionsMenu = ({
   const allActions = useMemo(
     () =>
       [
-        attachedFilesAction,
         mailMessagesAction,
         printAction,
         barcodeAction,
@@ -100,7 +96,6 @@ const HeaderOptionsMenu = ({
         .sort((a, b) => a.order - b.order),
     [
       actions,
-      attachedFilesAction,
       barcodeAction,
       jsonFieldsAction,
       mailMessagesAction,

packages/core/src/components/organisms/MailMessageCommentCard/MailMessageCommentCard.tsx

@@ -77,7 +77,7 @@ const MailMessageCommentCard = ({
   );
 
   const handleCommentAttachedFilesPress = useCallback(() => {
-    navigation.navigate('AttachedFilesScreen', {
+    navigation.navigate('MailMessageAttachedFilesScreen', {
       files: files,
     });
   }, [navigation, files]);

packages/core/src/components/templates/index.js

@@ -16,7 +16,6 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-export {default as AttachedFilesView} from './AttachedFilesView/AttachedFilesView';
 export {default as GlobalToolBox} from './GlobalToolBox/GlobalToolBox';
 export {default as MailMessageView} from './MailMessageView/MailMessageView';
 export {default as PeriodInput} from './PeriodInput/PeriodInput';

packages/core/src/features/attachedFilesSlice.js

@@ -18,22 +18,8 @@
 
 import {createAsyncThunk, createSlice} from '@reduxjs/toolkit';
 import {handlerApiCall} from '../apiProviders/utils';
-import {countAttachments, fetchAttachedFiles} from '../api/attached-files-api';
 import {fetchFileDetails} from '../api/metafile-api';
 
-export const getAttachedFiles = createAsyncThunk(
-  'attachedFiles/getAttachedFiles',
-  async function (data, {getState}) {
-    return handlerApiCall({
-      fetchFunction: fetchAttachedFiles,
-      data: data,
-      action: 'Base_SliceAction_FetchAttachedFiles',
-      getState: getState,
-      responseOptions: {isArrayResponse: true},
-    });
-  },
-);
-
 export const getAttachedFilesDetails = createAsyncThunk(
   'attachedFiles/getAttachedFilesDetails',
   async function (data, {getState}) {
@@ -47,50 +33,22 @@ export const getAttachedFilesDetails = createAsyncThunk(
   },
 );
 
-export const countAttachmentFiles = createAsyncThunk(
-  'attachedFiles/countAttachmentFiles',
-  async function (data, {getState}) {
-    return handlerApiCall({
-      fetchFunction: countAttachments,
-      data: data,
-      action: 'Base_SliceAction_CountAttachedFiles',
-      getState: getState,
-      responseOptions: {isArrayResponse: true, returnTotal: true},
-    });
-  },
-);
-
 const initialState = {
   loading: false,
   attachedFilesList: [],
-  attachments: 0,
 };
 
 const attachedFilesSlice = createSlice({
   name: 'attachedFiles',
   initialState,
   extraReducers: builder => {
-    builder.addCase(getAttachedFiles.pending, state => {
-      state.loading = true;
-    });
-    builder.addCase(getAttachedFiles.fulfilled, (state, action) => {
-      state.loading = false;
-      state.attachedFilesList = action.payload;
-    });
     builder.addCase(getAttachedFilesDetails.pending, state => {
       state.loading = true;
     });
     builder.addCase(getAttachedFilesDetails.fulfilled, (state, action) => {
       state.loading = false;
       state.attachedFilesList = action.payload;
     });
-    builder.addCase(countAttachmentFiles.pending, state => {
-      state.loading = true;
-    });
-    builder.addCase(countAttachmentFiles.fulfilled, (state, action) => {
-      state.loading = false;
-      state.attachments = action.payload;
-    });
   },
 });